Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows ersatz problems #2244

Closed
7 tasks done
dankamongmen opened this issue Oct 7, 2021 · 2 comments
Closed
7 tasks done

windows ersatz problems #2244

dankamongmen opened this issue Oct 7, 2021 · 2 comments
Assignees
@dankamongmen
Labels
bug Something isn't working demo relevant to notcurses-demo mswindows microsoft windows
Milestone
3.0.0

Comments

@dankamongmen
Copy link
Owner

dankamongmen commented Oct 7, 2021 •
edited
Loading

Some things I've noticed recently working on windows:

  • uniblock is broken with "couldn't convert 256 (100) () (Illegal byte sequence)"
  • notcurses-info prints no glyphs on a line after any failed glyph, it seems
  • can we detect whether we're in a working mintty? i think so -- error out on windows if we can't get ConsoleHandles (see misidentifying mintty as windows terminal #2248)
  • normal fails on bad rotation characters 0xe2, happens on first rotation
  • animate fails
  • need pipe-like input notification
  • [eagle] fails somewhere in ncvisual_destroy(), and it's an immediate exit, not a true error

i'd like to have notcurses-demo working all the way through on windows soon.
@dankamongmen dankamongmen added bug Something isn't working mswindows microsoft windows labels Oct 7, 2021
@dankamongmen dankamongmen added this to the 3.0.0 milestone Oct 7, 2021
@dankamongmen dankamongmen self-assigned this Oct 7, 2021
@dankamongmen
Copy link
Owner Author

c32rtomb() works to convert most of our unicode glyphs. nl_langinfo() indicates "UTF-8".

@dankamongmen dankamongmen mentioned this issue Oct 9, 2021
Closed
dankamongmen added a commit that referenced this issue Oct 9, 2021
@dankamongmen
[windows] exit if we can't get ConsoleHandles #2244
e8df81e
dankamongmen added a commit that referenced this issue Oct 11, 2021
@dankamongmen
[windows] use CreatePipe for input #2244
98e2817
dankamongmen added a commit that referenced this issue Oct 11, 2021
@dankamongmen
[input] read and write to Windows readiness handles #2244
bb5c2ec
@dankamongmen dankamongmen mentioned this issue Oct 12, 2021
Merged
dankamongmen added a commit that referenced this issue Oct 12, 2021
@dankamongmen
[input] read and write to Windows readiness handles #2244
f1148ac
dankamongmen added a commit that referenced this issue Oct 12, 2021
@dankamongmen
[input] read and write to Windows readiness handles #2244
f93faee
dankamongmen added a commit that referenced this issue Oct 14, 2021
@dankamongmen
Use Windows pipes for input readiness notification (#2263)
245f9f8 
* [windows] use CreatePipe for input #2244
* [input] read and write to Windows readiness handles #2244
* inputready_fd: not on windows, alas
dankamongmen added a commit that referenced this issue Oct 16, 2021
@dankamongmen @joseluis
Dankamongmen/ncvisual blit (#2276)
31bd0e2 
* [heuristics] GNU screen 4x never has rgb

* [BitmapSmoothMove] only WARN in test until sixel supports this #2258

* add minimal example for #2266

* contour: enable sextants

* interp PoC: clean up ncvisual #2266

* ncselector_options: constify string arguments

* Constify strings in selector/mselector_items

Use internal types to track items within the
selector/mselector widgets, rather than pressing the
user-provided item structs into double-duty. With this
change, we can constify the strings within those
user-provided items. Do so, also removing the internal-side
elements. Update documentation. Closes #2267.

* constify ncmenu_item/_section strings

* Use Windows pipes for input readiness notification (#2263)

* [windows] use CreatePipe for input #2244
* [input] read and write to Windows readiness handles #2244
* inputready_fd: not on windows, alas

* for now, if it's on windows, it's windows terminal #2248

* tabbed janitorial work

clean up memory leak of tab names
ignore NCTYPE_RELEASE in tabbed PoC
constify strings in nctabbed_options

* notcurses-demo FPS graph: back to straight seconds

* [info] expand some emoji into proper literals

* drop textplay PoC

* remove poc for issue #2266

* constify ncselector_item reference fix #2270

* [ncplayer] restore pause functionality with NCTYPE_RELEASE

* stop pushing termtype to interrogate_terminfo

* menu PoC: ignore NCTYPE_RELEASE

* properly name Windows Terminal

* [windows] HANDLE, not PHANDLE

* ncvisual_render -> ncvisual_blit (core/test) #1462

* ncvisual_render -> ncvisual_blit (docs)

* ncvisual_render -> ncvisual_blit (nctetris)

* [keller] fix up for ncvisual_blit() #1462

* stacking tests: ncvisual_render() -> ncvisual_blit() #1462

* all PoCs: ncvisual_render -> ncvisual_blit #1462

* restore ncvisual_inflate(), for now

* pixel PoC / ncneofetch -> ncvisual_blit() #1462

* notcurses-info: ncvisual_blit, inline all emoji #1462

* rotate PoCpp: ncvisual_blit() #1462

* xray/grid: ncvisual_blit() #1462

* remove last instances of ncvisual_render() #1462

* remove old-style notcurses_ rendering functions

Make notcurses_render() a static inline wrapper around
ncpile_render(). Remove the deprecated
notcurses_render_to_file() and ncpile_render_to_file().
ABI3 work #1777.

* ncstrwidth() becomes static inline wrapper #1777

* remove deprecated ncvisual_subtitle()

* kill ncvisual_inflate(), long deprecated #1777

* remove deprecated palette256 wrappers #1777

* kill ncplane_new() #1777

* remove deprecated renderfp field from notcurses_options #1777

* reorder ncstats fields to match documentation #1777

* kill deprecated style functions #1777

* ncplane_move{top, bottom} become static inline #1777

* fix up move_above()/move_below() #1777

* ncplane_pixelgeom -> ncplane_pixel_geom() #1777

* ncstyle functions ought return uint16_t #1777 #2200

* ncvisualplane_create: provide new pile functionality #1462

* introduce ncvisual_blit() #1462

* reduce ncvisual_render() to wrapper around ncvisual_blit() #1462

* convert most ncvisual_render()s to ncvisual_blit() #1642

Co-authored-by: joseLuís <joseluis@andamira.net>
@dankamongmen dankamongmen added the demo relevant to notcurses-demo label Nov 2, 2021
@dankamongmen
Copy link
Owner Author

most of these problems were fixed as part of the work on #2117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dankamongmen dankamongmen

Labels
bug Something isn't working demo relevant to notcurses-demo mswindows microsoft windows
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@dankamongmen