Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add USE_TFMAN_STATIC option #2664

Closed
wants to merge 1 commit into from

Conversation

data-man
Copy link
Contributor

No description provided.

@dankamongmen
Copy link
Owner

man, sorry for missing this for like...six months. geez.

i like it, but i think it ought apply to all the binaries. would oyu be down to change it to USE_STATIC_BINS and set the flags for all bins? thanks! i'll then merge it.

@dankamongmen
Copy link
Owner

ok, i've taken this and changed USE_STATIC_TFMAN to USE_STATIC_BINARIES, and changed it to OFF by default, as described above.

@dankamongmen
Copy link
Owner

this is being done in the data-man-tfman_static branch

dankamongmen added a commit that referenced this pull request Dec 31, 2024
based off @data-man's work in #2664, add a
USE_STATIC_BINARIES option to CMake, dependent on
USE_STATIC being set. when this option is used,
link the notcurses binaries against the static
versions of notcurses. i've done ncman and nctetris
thus far. also, move to pkgconf for libdeflate,
requiring at least version 1.9 (that's when i added
the pkgconfig code upstream).
dankamongmen added a commit that referenced this pull request Dec 31, 2024
based off @data-man's work in #2664, add a
USE_STATIC_BINARIES option to CMake, dependent on
USE_STATIC being set. when this option is used,
link the notcurses binaries against the static
versions of notcurses. i've done ncman and nctetris
thus far. also, move to pkgconf for libdeflate,
requiring at least version 1.9 (that's when i added
the pkgconfig code upstream).
dankamongmen added a commit that referenced this pull request Dec 31, 2024
based off @data-man's work in #2664, add a
USE_STATIC_BINARIES option to CMake, dependent on
USE_STATIC being set. when this option is used,
link the notcurses binaries against the static
versions of notcurses. i've done ncman and nctetris
thus far. also, move to pkgconf for libdeflate,
requiring at least version 1.9 (that's when i added
the pkgconfig code upstream).
@dankamongmen
Copy link
Owner

Merged via #2824 . Thank you for your contribution to Notcurses!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants