-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fixed platforms lookup / set proper platform type for unix32-unsigned and unix64-unsigned / copy platforms in CMake
#4464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
unix32-unsigned and unix64-unsignedunix32-unsigned and unix64-unsigned / improved TestCmdlineParser
7e9878e to
fae0a79
Compare
unix32-unsigned and unix64-unsigned / improved TestCmdlineParserunix32-unsigned and unix64-unsigned / copy platforms in CMake / improved TestCmdlineParser
d866194 to
947c528
Compare
unix32-unsigned and unix64-unsigned / copy platforms in CMake / improved TestCmdlineParserplatforms lookup / set proper platform type for unix32-unsigned and unix64-unsigned / copy platforms in CMake
947c528 to
b3dae01
Compare
| bool success = false; | ||
| for (const std::string & f : filenames) { | ||
| if (verbose) | ||
| std::cout << "try to load platform file '" << f << "' ... "; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not output any important information with std::cout directly. Is it just for debugging? It will not be shown properly in the GUI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's verbose information. I just checked other code and that uses the ErrorLogger::reportOut(). Will adjust.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out that is not the function to use since it is not available at that point.
Also the rest of the code is not doing this consistently either. So I propose to apply these changes as is. With a later PR I will refactor out the explicit std::cout and std::cerr usage as a whole.
|
Can this be merged? It blocks further improvements. |
|
After this change. some tests in TestCmdlineParser fail on Windows using the supplied project files: |
|
I baffled as the CI is fine. Maybe the platform files were not properly copied on your system. |
|
Apparently, the test is executed in the |
Extracted from #4325.
This is the first step in getting rid of hard-coded platforms and should have no effect at all beside making it consistent (and uncovering issues).