Skip to content

Conversation

@firewave
Copy link
Collaborator

@firewave firewave commented Jul 29, 2022

No description provided.

@firewave firewave force-pushed the platform-2 branch 2 times, most recently from 0ce9cf1 to 94079c3 Compare July 29, 2022 15:48
TEST_CASE(stdcpp11);
TEST_CASE(stdunknown);
TEST_CASE(platform);
TEST_CASE(platform2);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you name the test function according to the platform file tested? e.g. platform_win64 etc.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those will probably go away soon anyways because of the incremental nature...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@firewave firewave marked this pull request as draft July 29, 2022 16:04
@firewave
Copy link
Collaborator Author

This breaks cppcheck-gui since it relies on the built-in platforms. Seems I need to change everything first and create smaller parts from that.

Since I just wanted to get my backlog'd changes into the tree and those are incomplete this PR will unfortunately sit a while.

@firewave
Copy link
Collaborator Author

I removed the deprecation stuff as it is part of a separate PR.

@firewave firewave marked this pull request as ready for review August 10, 2023 07:29
@firewave firewave marked this pull request as draft August 10, 2023 07:46
@firewave
Copy link
Collaborator Author

The tests are affected by no platform data being set on Windows. The platform file loading is part of the command-line parsing and is not executed before the tests. When the windows platform non-builtin causes no data to be set. Before we can merge this we need to remove those first. Fortunately there are already scheduled to be removed in the next dev cycle.

@firewave firewave force-pushed the platform-2 branch 3 times, most recently from 51e5d3c to afe9af1 Compare September 12, 2023 13:52
@firewave
Copy link
Collaborator Author

For some reason the validation is not able to read <default-sign>&#x000;</default-sign> because it says that 0 is an invalid xmlChar. The application code handles it fine.

But I think we should not have this. The built-in configurations currently default to the signedness of the binary which I think is wrong. Same as we were defaulting to a Windows platform in Windows binaries. Those should possibly be signed by default. We already have unsigned for unix so you could already fixate that.

We also should probably have a command-line option similar to -fsigned-char/-funsigned-char instead. This is rather specified by the compiler than the actual platform.

This is something I have to think about and I am gonna finish #5414 first as this also plays into it.

@firewave firewave force-pushed the platform-2 branch 3 times, most recently from 428c2d3 to 15ec9cd Compare September 19, 2023 15:58
@firewave firewave marked this pull request as ready for review September 19, 2023 15:59
@firewave firewave marked this pull request as draft September 19, 2023 19:25
@firewave
Copy link
Collaborator Author

firewave commented Oct 8, 2023

Having \0 in the character sign field makes no sense at all. We are provide a fixed platform and then we are basing that value on the compiler - that just seems wrong. I will drop that and go for signed by default as the common compilers do and add an additional option to control that in a different PR first.

@firewave firewave force-pushed the platform-2 branch 2 times, most recently from f3f5234 to 0e20094 Compare October 20, 2023 09:58
@firewave firewave force-pushed the platform-2 branch 2 times, most recently from b14a38e to d80b6c3 Compare November 25, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants