fixed #14384 - added Platform::windows to specify if a platform is a Windows one
#4960
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
This also needs some kind of hook to implicitly replace the |
firewave
force-pushed
the
platfowm-w
branch
from
4791f58 to
5ce4035
Compare
firewave
changed the title
Platform attributesPlatform attributes
firewave
force-pushed
the
platfowm-w
branch
3 times, most recently
from
e0d41c0 to
88a72a9
Compare
firewave
force-pushed
the
platfowm-w
branch
3 times, most recently
from
4b7d4d7 to
e1c108a
Compare
|
firewave
changed the title
Platform attributesPlatform::windows to specify if a platform is a Windows one
firewave
changed the title
Platform::windows to specify if a platform is a Windows onePlatform::windows to specify if a platform is a Windows one
I filed about it https://trac.cppcheck.net/ticket/14385. This ties into the proper handling of the |
| case Type::Win32W: | ||
| case Type::Win32A: | ||
| type = t; | ||
| windows = true; |
There was a problem hiding this comment.
let's try to support arbitrary usage of this class.
windows should be assigned always so that it will be false for a unix platform.
Platform p;
p.set(win64);
p.set(unix64);
I think p.windows is true
There was a problem hiding this comment.
Done, but the problem also exists for any field when loading from a XML. I added a TODO about it.
This plays into the discussion in #5458. If we made unspecified the default and no longer make it user selectable we could use that as an initial state when no other platform has been/could be loaded.
I will look into it while working on/towards #4325.
|
2 participants
No description provided.