use libc++ in conjunction with Clang in CI #6820

firewave · 2024-09-22T17:28:46Z

It provides additional annotations for the compiler and the sanitizers to detect more issues.

firewave · 2024-09-22T19:02:06Z

[238/238][20.0s] clang-tidy-19 -p=/home/runner/work/cppcheck/cppcheck/cmake.output -quiet /home/runner/work/cppcheck/cppcheck/gui/xmlreport.cpp
/home/runner/work/cppcheck/cppcheck/lib/utils.h:57:5: error: an exception may be thrown in function '~OnExit' which should not throw exceptions [bugprone-exception-escape,-warnings-as-errors]
   57 |     ~OnExit() {
      |     ^

I filed a ticket about the OnExit bugprone-exception-escape false positive(?) upstream: llvm/llvm-project#109587.

firewave · 2025-06-25T10:36:45Z

lib/programmemory.cpp

                return Token::Match(child, "&&|%oror%");
            }))
                return false;
+            // NOLINTNEXTLINE(bugprone-nondeterministic-pointer-iteration-order) - FP with libc++ only


I filed llvm/llvm-project#145665 and llvm/llvm-project#145667 about this.

sonarqubecloud · 2025-08-04T18:47:42Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

firewave · 2025-08-04T19:53:16Z

lib/utils.h

 struct OnExit {
    std::function<void()> f;

+    // NOLINTNEXTLINE(bugprone-exception-escape) - reported with libc++ for any files which includes this (even if not used)


/home/runner/work/cppcheck/cppcheck/lib/utils.h:57:5: error: an exception may be thrown in function '~OnExit' which should not throw exceptions [bugprone-exception-escape,-warnings-as-errors] 57 | ~OnExit() { | ^ /usr/lib/llvm-21/bin/../include/c++/v1/__functional/function.h:74:3: note: frame #0: unhandled exception of type 'std::bad_function_call' may be thrown in function '__throw_bad_function_call' here 74 | throw bad_function_call(); | ^ /usr/lib/llvm-21/bin/../include/c++/v1/__functional/function.h:273:7: note: frame #1: function 'operator()' calls function '__throw_bad_function_call' here 273 | std::__throw_bad_function_call(); | ^ /usr/lib/llvm-21/bin/../include/c++/v1/__functional/function.h:772:10: note: frame #2: function 'operator()' calls function 'operator()' here 772 | return __f_(std::forward<_ArgTypes>(__arg)...); | ^ /home/runner/work/cppcheck/cppcheck/lib/utils.h:58:10: note: frame #3: function '~OnExit' calls function 'operator()' here 58 | f(); | ^

Reported upstream as llvm/llvm-project#109587.

firewave · 2025-08-04T19:54:17Z

lib/tokenlist.cpp

    struct OnException {
        std::function<void()> f;

+        // NOLINTNEXTLINE(bugprone-exception-escape)


/home/runner/work/cppcheck/cppcheck/lib/tokenlist.cpp:1844:9: error: an exception may be thrown in function '~OnException' which should not throw exceptions [bugprone-exception-escape,-warnings-as-errors] 1844 | ~OnException() { | ^ /usr/lib/llvm-21/bin/../include/c++/v1/__functional/function.h:74:3: note: frame #0: unhandled exception of type 'std::bad_function_call' may be thrown in function '__throw_bad_function_call' here 74 | throw bad_function_call(); | ^ /usr/lib/llvm-21/bin/../include/c++/v1/__functional/function.h:273:7: note: frame #1: function 'operator()' calls function '__throw_bad_function_call' here 273 | std::__throw_bad_function_call(); | ^ /usr/lib/llvm-21/bin/../include/c++/v1/__functional/function.h:772:10: note: frame #2: function 'operator()' calls function 'operator()' here 772 | return __f_(std::forward<_ArgTypes>(__arg)...); | ^ /home/runner/work/cppcheck/cppcheck/lib/tokenlist.cpp:1847:18: note: frame #3: function '~OnException' calls function 'operator()' here 1847 | f(); | ^

firewave · 2025-08-04T19:54:46Z

lib/templatesimplifier.cpp

        const Token * const mToken;
    };

+    // NOLINTNEXTLINE(bugprone-exception-escape)


/home/runner/work/cppcheck/cppcheck/lib/templatesimplifier.cpp:77:11: error: an exception may be thrown in function 'FindName' which should not throw exceptions [bugprone-exception-escape,-warnings-as-errors] 77 | class FindName { | ^ /usr/lib/llvm-21/bin/../include/c++/v1/stdexcept:243:3: note: frame #0: unhandled exception of type 'std::length_error' may be thrown in function '__throw_length_error' here 243 | throw length_error(__msg); | ^ /usr/lib/llvm-21/bin/../include/c++/v1/string:2463:5: note: frame #1: function '__throw_length_error' calls function '__throw_length_error' here 2463 | std::__throw_length_error("basic_string"); | ^ /usr/lib/llvm-21/bin/../include/c++/v1/string:2569:7: note: frame #2: function '__init_copy_ctor_external' calls function '__throw_length_error' here 2569 | this->__throw_length_error(); | ^ /usr/lib/llvm-21/bin/../include/c++/v1/string:997:7: note: frame #3: function 'basic_string' calls function '__init_copy_ctor_external' here 997 | __init_copy_ctor_external(std::__to_address(__str.__get_long_pointer()), __str.__get_long_size()); | ^ /home/runner/work/cppcheck/cppcheck/lib/templatesimplifier.cpp:77:11: note: frame #4: function 'FindName' calls function 'basic_string' here 77 | class FindName { | ^

firewave · 2025-08-04T19:55:04Z

lib/templatesimplifier.cpp

        const std::string mName;
    };

+    // NOLINTNEXTLINE(bugprone-exception-escape)


/home/runner/work/cppcheck/cppcheck/lib/templatesimplifier.cpp:87:11: error: an exception may be thrown in function 'FindFullName' which should not throw exceptions [bugprone-exception-escape,-warnings-as-errors] 87 | class FindFullName { | ^ /usr/lib/llvm-21/bin/../include/c++/v1/stdexcept:243:3: note: frame #0: unhandled exception of type 'std::length_error' may be thrown in function '__throw_length_error' here 243 | throw length_error(__msg); | ^ /usr/lib/llvm-21/bin/../include/c++/v1/string:2463:5: note: frame #1: function '__throw_length_error' calls function '__throw_length_error' here 2463 | std::__throw_length_error("basic_string"); | ^ /usr/lib/llvm-21/bin/../include/c++/v1/string:2569:7: note: frame #2: function '__init_copy_ctor_external' calls function '__throw_length_error' here 2569 | this->__throw_length_error(); | ^ /usr/lib/llvm-21/bin/../include/c++/v1/string:997:7: note: frame #3: function 'basic_string' calls function '__init_copy_ctor_external' here 997 | __init_copy_ctor_external(std::__to_address(__str.__get_long_pointer()), __str.__get_long_size()); | ^ /home/runner/work/cppcheck/cppcheck/lib/templatesimplifier.cpp:87:11: note: frame #4: function 'FindFullName' calls function 'basic_string' here 87 | class FindFullName { | ^

firewave · 2025-08-04T19:55:40Z

lib/importproject.cpp


 ImportProject::SharedItemsProject ImportProject::importVcxitems(const std::string& filename, const std::vector<std::string>& fileFilters, std::vector<SharedItemsProject> &cache)
 {
+    // NOLINTNEXTLINE(bugprone-exception-escape)


/home/runner/work/cppcheck/cppcheck/lib/importproject.cpp:912:27: error: an exception may be thrown in function '(lambda at /home/runner/work/cppcheck/cppcheck/lib/importproject.cpp:912:27)' which should not throw exceptions [bugprone-exception-escape,-warnings-as-errors] 912 | auto isInCacheCheck = [filename](const ImportProject::SharedItemsProject& e) -> bool { | ^ /usr/lib/llvm-21/bin/../include/c++/v1/stdexcept:243:3: note: frame #0: unhandled exception of type 'std::length_error' may be thrown in function '__throw_length_error' here 243 | throw length_error(__msg); | ^ /usr/lib/llvm-21/bin/../include/c++/v1/string:2463:5: note: frame #1: function '__throw_length_error' calls function '__throw_length_error' here 2463 | std::__throw_length_error("basic_string"); | ^ /usr/lib/llvm-21/bin/../include/c++/v1/string:2569:7: note: frame #2: function '__init_copy_ctor_external' calls function '__throw_length_error' here 2569 | this->__throw_length_error(); | ^ /usr/lib/llvm-21/bin/../include/c++/v1/string:997:7: note: frame #3: function 'basic_string' calls function '__init_copy_ctor_external' here 997 | __init_copy_ctor_external(std::__to_address(__str.__get_long_pointer()), __str.__get_long_size()); | ^ /home/runner/work/cppcheck/cppcheck/lib/importproject.cpp:912:27: note: frame #4: function '(lambda at /home/runner/work/cppcheck/cppcheck/lib/importproject.cpp:912:27)' calls function 'basic_string' here 912 | auto isInCacheCheck = [filename](const ImportProject::SharedItemsProject& e) -> bool { | ^

This is fixed by passing it by reference instead of copying it.

firewave · 2025-08-04T19:56:23Z

gui/main.cpp

 static void ShowVersion();
 static bool CheckArgs(const QStringList &args);

+// NOLINTNEXTLINE(bugprone-exception-escape)


/home/runner/work/cppcheck/cppcheck/gui/main.cpp:48:5: error: an exception may be thrown in function 'main' which should not throw exceptions [bugprone-exception-escape,-warnings-as-errors] 48 | int main(int argc, char *argv[]) | ^ /usr/lib/llvm-21/bin/../include/c++/v1/__new/exceptions.h:66:3: note: frame #0: unhandled exception of type 'std::bad_array_new_length' may be thrown in function '__throw_bad_array_new_length' here 66 | throw bad_array_new_length(); | ^ /usr/lib/llvm-21/bin/../include/c++/v1/__memory/allocator.h:101:7: note: frame #1: function 'allocate' calls function '__throw_bad_array_new_length' here 101 | std::__throw_bad_array_new_length(); | ^ /usr/lib/llvm-21/bin/../include/c++/v1/__memory/allocate_at_least.h:41:11: note: frame #2: function '__allocate_at_least<std::allocator<char>>' calls function 'allocate' here 41 | return {__alloc.allocate(__n), __n}; | ^ /usr/lib/llvm-21/bin/../include/c++/v1/string:2545:25: note: frame #3: function '__init' calls function '__allocate_at_least<std::allocator<char>>' here 2545 | auto __allocation = std::__allocate_at_least(__alloc_, __recommend(__sz) + 1); | ^ /usr/lib/llvm-21/bin/../include/c++/v1/string:1053:5: note: frame #4: function 'basic_string<0>' calls function '__init' here 1053 | __init(__s, traits_type::length(__s)); | ^ /home/runner/work/cppcheck/cppcheck/gui/main.cpp:132:17: note: frame #5: function 'ShowVersion' calls function 'basic_string<0>' here 132 | std::string versionMessage("Cppcheck "); | ^ /home/runner/work/cppcheck/cppcheck/gui/main.cpp:92:9: note: frame #6: function 'CheckArgs' calls function 'ShowVersion' here 92 | ShowVersion(); | ^ /home/runner/work/cppcheck/cppcheck/gui/main.cpp:70:10: note: frame #7: function 'main' calls function 'CheckArgs' here 70 | if (!CheckArgs(QApplication::arguments())) | ^

firewave · 2025-08-04T19:56:53Z

lib/ctu.h

            bool loadBaseFromXml(const tinyxml2::XMLElement *xmlElement);
        };

+        // NOLINTNEXTLINE(bugprone-exception-escape)


/home/runner/work/cppcheck/cppcheck/lib/ctu.h:112:15: error: an exception may be thrown in function 'FunctionCall' which should not throw exceptions [bugprone-exception-escape,-warnings-as-errors] 112 | class FunctionCall : public CallBase { | ^ /usr/lib/llvm-21/bin/../include/c++/v1/stdexcept:243:3: note: frame #0: unhandled exception of type 'std::length_error' may be thrown in function '__throw_length_error' here 243 | throw length_error(__msg); | ^ /usr/lib/llvm-21/bin/../include/c++/v1/string:2463:5: note: frame #1: function '__throw_length_error' calls function '__throw_length_error' here 2463 | std::__throw_length_error("basic_string"); | ^ /usr/lib/llvm-21/bin/../include/c++/v1/string:2569:7: note: frame #2: function '__init_copy_ctor_external' calls function '__throw_length_error' here 2569 | this->__throw_length_error(); | ^ /usr/lib/llvm-21/bin/../include/c++/v1/string:997:7: note: frame #3: function 'basic_string' calls function '__init_copy_ctor_external' here 997 | __init_copy_ctor_external(std::__to_address(__str.__get_long_pointer()), __str.__get_long_size()); | ^ /home/runner/work/cppcheck/cppcheck/lib/ctu.h:102:13: note: frame #4: function 'CallBase' calls function 'basic_string' here 102 | CallBase(const CallBase&) = default; | ^ /home/runner/work/cppcheck/cppcheck/lib/ctu.h:112:15: note: frame #5: function 'FunctionCall' calls function 'CallBase' here 112 | class FunctionCall : public CallBase { | ^

firewave · 2025-08-04T19:57:08Z

lib/ctu.h

            bool loadFromXml(const tinyxml2::XMLElement *xmlElement);
        };

+        // NOLINTNEXTLINE(bugprone-exception-escape)


/home/runner/work/cppcheck/cppcheck/lib/ctu.h:124:15: error: an exception may be thrown in function 'NestedCall' which should not throw exceptions [bugprone-exception-escape,-warnings-as-errors] 124 | class NestedCall : public CallBase { | ^ /usr/lib/llvm-21/bin/../include/c++/v1/stdexcept:243:3: note: frame #0: unhandled exception of type 'std::length_error' may be thrown in function '__throw_length_error' here 243 | throw length_error(__msg); | ^ /usr/lib/llvm-21/bin/../include/c++/v1/string:2463:5: note: frame #1: function '__throw_length_error' calls function '__throw_length_error' here 2463 | std::__throw_length_error("basic_string"); | ^ /usr/lib/llvm-21/bin/../include/c++/v1/string:2569:7: note: frame #2: function '__init_copy_ctor_external' calls function '__throw_length_error' here 2569 | this->__throw_length_error(); | ^ /usr/lib/llvm-21/bin/../include/c++/v1/string:997:7: note: frame #3: function 'basic_string' calls function '__init_copy_ctor_external' here 997 | __init_copy_ctor_external(std::__to_address(__str.__get_long_pointer()), __str.__get_long_size()); | ^ /home/runner/work/cppcheck/cppcheck/lib/ctu.h:102:13: note: frame #4: function 'CallBase' calls function 'basic_string' here 102 | CallBase(const CallBase&) = default; | ^ /home/runner/work/cppcheck/cppcheck/lib/ctu.h:124:15: note: frame #5: function 'NestedCall' calls function 'CallBase' here 124 | class NestedCall : public CallBase { | ^

Reported upstream as llvm/llvm-project#152026.

This also lacks the actual source location which is triggering it. I was not able to get a minimized example for that yet.

firewave · 2025-08-04T19:57:42Z

tools/dmake/dmake.cpp

    fout << "\t$(CXX) ${LIB_FUZZING_ENGINE} $(CPPFLAGS) $(CXXFLAGS) -DNO_FUZZ -c -o $@ main.cpp\n";
 }

+// NOLINTNEXTLINE(bugprone-exception-escape)


/home/runner/work/cppcheck/cppcheck/tools/dmake/dmake.cpp:417:5: error: an exception may be thrown in function 'main' which should not throw exceptions [bugprone-exception-escape,-warnings-as-errors] 417 | int main(int argc, char **argv) | ^ /usr/bin/../include/c++/v1/stdexcept:251:3: note: frame #0: unhandled exception of type 'std::out_of_range' may be thrown in function '__throw_out_of_range' here 251 | throw out_of_range(__msg); | ^ /usr/bin/../include/c++/v1/string:2467:5: note: frame #1: function '__throw_out_of_range' calls function '__throw_out_of_range' here 2467 | std::__throw_out_of_range("basic_string"); | ^ /usr/bin/../include/c++/v1/string:3528:5: note: frame #2: function 'compare' calls function '__throw_out_of_range' here 3528 | this->__throw_out_of_range(); | ^ /usr/bin/../include/c++/v1/string:2025:12: note: frame #3: function 'compare' calls function 'compare' here 2025 | return compare(__pos1, __n1, __s, traits_type::length(__s)); | ^ /home/runner/work/cppcheck/cppcheck/cli/../lib/utils.h:97:12: note: frame #4: function 'startsWith' calls function 'compare' here 97 | return str.compare(0, startlen, start) == 0; | ^ /home/runner/work/cppcheck/cppcheck/cli/../lib/utils.h:103:12: note: frame #5: function 'startsWith<11UL>' calls function 'startsWith' here 103 | return startsWith(str, start, N - 1); | ^ /home/runner/work/cppcheck/cppcheck/tools/dmake/dmake.cpp:151:29: note: frame #6: function 'compilefiles' calls function 'startsWith<11UL>' here 151 | const bool external(startsWith(file,"externals/") || startsWith(file,"../externals/")); | ^ /home/runner/work/cppcheck/cppcheck/tools/dmake/dmake.cpp:873:5: note: frame #7: function 'main' calls function 'compilefiles' here 873 | compilefiles(fout, libfiles_prio, "${INCLUDE_FOR_LIB}"); | ^

sonarqubecloud · 2025-09-10T08:45:19Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

…tion-order` clang-tidy false positive

…ead-safety-beta` Clang warnings

sonarqubecloud · 2025-10-22T21:32:29Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

firewave force-pushed the libcxx-ci branch 2 times, most recently from 98c59ce to d1247cd Compare September 22, 2024 17:35

This comment was marked as resolved.

Sign in to view

firewave force-pushed the libcxx-ci branch from 89bbce8 to 9f46748 Compare November 14, 2024 21:19

firewave mentioned this pull request Nov 14, 2024

some adjustments for libc++ #7006

Merged

firewave force-pushed the libcxx-ci branch 2 times, most recently from 0dd91f3 to 94cd174 Compare December 20, 2024 20:44

This comment was marked as resolved.

Sign in to view

firewave force-pushed the libcxx-ci branch from 94cd174 to 219513d Compare January 26, 2025 22:26

firewave force-pushed the libcxx-ci branch from 219513d to 4d38c03 Compare March 25, 2025 08:55

firewave force-pushed the libcxx-ci branch 2 times, most recently from 09658c1 to 2d9a71d Compare June 25, 2025 10:23

firewave commented Jun 25, 2025

View reviewed changes

firewave force-pushed the libcxx-ci branch from 2d9a71d to ed782ac Compare August 4, 2025 18:46

firewave force-pushed the libcxx-ci branch from 85e489c to ff8800f Compare August 4, 2025 19:52

firewave commented Aug 4, 2025

View reviewed changes

firewave force-pushed the libcxx-ci branch from ff8800f to ae5503a Compare September 10, 2025 08:39

firewave force-pushed the libcxx-ci branch from ae5503a to 2111990 Compare October 22, 2025 20:36

firewave added 5 commits October 22, 2025 23:22

use libc++ in conjunction with Clang in CI

da20b31

remove

cc52d7a

mitigated bugprone-exception-escape clang-tidy warnings

2f77f3e

programmemory.cpp: mitigated `bugprone-nondeterministic-pointer-itera…

83542b5

…tion-order` clang-tidy false positive

compileroptions.cmake: disabled -Wthread-safety-negative and `-Wthr…

6b5785c

…ead-safety-beta` Clang warnings

firewave force-pushed the libcxx-ci branch from 2111990 to 6b5785c Compare October 22, 2025 21:24

use libc++ in conjunction with Clang in CI #6820

Are you sure you want to change the base?

use libc++ in conjunction with Clang in CI #6820

Uh oh!

Conversation

firewave commented Sep 22, 2024

Uh oh!

firewave commented Sep 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Aug 4, 2025

Quality Gate passed

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Sep 10, 2025

Quality Gate passed

Uh oh!

sonarqubecloud bot commented Oct 22, 2025

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

firewave commented Sep 22, 2024 •

edited

Loading