Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16781 client: Allow daos_metrics read via pid #15448

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Conversation

mjmac
Copy link
Contributor

@mjmac mjmac commented Nov 5, 2024

In cases where the client telemetry has been manually
enabled, daos_metrics should be able to read it as
long as the client's PID is known and the user has
read access to the shared memory segment.

Moves the daos_metrics utility into the common daos
package for use from both server and client sides.

Features: telemetry
Required-githooks: true
Change-Id: I660dd758314a9c48a486f51647a1b497c8e27bd9
Signed-off-by: Michael MacDonald mjmac@google.com

Verified

This commit was signed with the committer’s verified signature. The key has expired.
HighCrit HighCrit
In cases where the client telemetry has been manually
enabled, daos_metrics should be able to read it as
long as the client's PID is known and the user has
read access to the shared memory segment.

Features: telemetry
Required-githooks: true

Change-Id: I660dd758314a9c48a486f51647a1b497c8e27bd9
Signed-off-by: Michael MacDonald <mjmac@google.com>
@mjmac mjmac requested a review from a team as a code owner November 5, 2024 16:59
Copy link

github-actions bot commented Nov 5, 2024

Ticket title is 'Allow daos_metrics to read client metrics by PID'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-16781

Verified

This commit was signed with the committer’s verified signature. The key has expired.
HighCrit HighCrit
Features: telemetry
Required-githooks: true

Change-Id: Icb0cfc45a318035aa82f3e1add093b737ef32dff
Signed-off-by: Michael MacDonald <mjmac@google.com>
@mjmac mjmac requested review from a team as code owners November 5, 2024 19:15
Features: telemetry
Required-githooks: true

Change-Id: I99f7cc7c21c06bce1bdcbcafd372bb94eb09d4db
Signed-off-by: Michael MacDonald <mjmac@google.com>
@mjmac mjmac requested a review from a team as a code owner November 5, 2024 19:57
@mjmac mjmac merged commit 4162161 into master Nov 7, 2024
56 checks passed
@mjmac mjmac deleted the mjmac/DAOS-16781 branch November 7, 2024 13:29
mjmac added a commit that referenced this pull request Nov 7, 2024
In cases where the client telemetry has been manually
enabled, daos_metrics should be able to read it as
long as the client's PID is known and the user has
read access to the shared memory segment.

Moves the daos_metrics utility into the common daos
package for use from both server and client sides.

Required-githooks: true

Change-Id: Ibdcbb88de450b02bf31513ca7fadf9d73f16bd97
Signed-off-by: Michael MacDonald <mjmac@google.com>
mjmac added a commit that referenced this pull request Nov 7, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
In cases where the client telemetry has been manually
enabled, daos_metrics should be able to read it as
long as the client's PID is known and the user has
read access to the shared memory segment.

Moves the daos_metrics utility into the common daos
package for use from both server and client sides.

Required-githooks: true

Change-Id: Ibdcbb88de450b02bf31513ca7fadf9d73f16bd97
Signed-off-by: Michael MacDonald <mjmac@google.com>
mjmac added a commit that referenced this pull request Nov 7, 2024
In cases where the client telemetry has been manually
enabled, daos_metrics should be able to read it as
long as the client's PID is known and the user has
read access to the shared memory segment.

Moves the daos_metrics utility into the common daos
package for use from both server and client sides.

Signed-off-by: Michael MacDonald <mjmac@google.com>
jolivier23 pushed a commit that referenced this pull request Feb 3, 2025
In cases where the client telemetry has been manually
enabled, daos_metrics should be able to read it as
long as the client's PID is known and the user has
read access to the shared memory segment.

Moves the daos_metrics utility into the common daos
package for use from both server and client sides.

Required-githooks: true

Change-Id: I1fab0e2fb4fe90228c5c5ff2aabc43122ace0c1c
Signed-off-by: Michael MacDonald <mjmac@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants