DAOS-16781 client: Allow daos_metrics read via pid (#15448) #15466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ticket title is 'Allow daos_metrics to read client metrics by PID' |
In cases where the client telemetry has been manually enabled, daos_metrics should be able to read it as long as the client's PID is known and the user has read access to the shared memory segment. Moves the daos_metrics utility into the common daos package for use from both server and client sides. Required-githooks: true Change-Id: Ibdcbb88de450b02bf31513ca7fadf9d73f16bd97 Signed-off-by: Michael MacDonald <mjmac@google.com>
mjmac
force-pushed
the
mjmac/DAOS-16781-google-2.6
branch
from
4451bff to
1992c4f
Compare
miroslavln
approved these changes
Nov 7, 2024
This was referenced Nov 9, 2024
This was referenced Nov 25, 2024
jolivier23
pushed a commit
that referenced
this pull request
Feb 3, 2025
In cases where the client telemetry has been manually enabled, daos_metrics should be able to read it as long as the client's PID is known and the user has read access to the shared memory segment. Moves the daos_metrics utility into the common daos package for use from both server and client sides. Required-githooks: true Change-Id: I1fab0e2fb4fe90228c5c5ff2aabc43122ace0c1c Signed-off-by: Michael MacDonald <mjmac@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where the client telemetry has been manually
enabled, daos_metrics should be able to read it as
long as the client's PID is known and the user has
read access to the shared memory segment.
Moves the daos_metrics utility into the common daos
package for use from both server and client sides.
Required-githooks: true
Change-Id: Ibdcbb88de450b02bf31513ca7fadf9d73f16bd97
Signed-off-by: Michael MacDonald mjmac@google.com