Skip to content

DAOS-6801 Security: Impelment Secure Erase for Credential memory #4690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Mar 10, 2021
Merged

DAOS-6801 Security: Impelment Secure Erase for Credential memory #4690

merged 14 commits into from
Mar 10, 2021

Conversation

dpquigl
Copy link
Contributor

@dpquigl dpquigl commented Feb 18, 2021

Security credentials could be grabbed from a core dump or memory dump and used
later if not freed securely. Implement a secure erase of the memory used for
the security credential.

Signed-off-by: David Quigley david.quigley@intel.com

@dpquigl
DAOS-6801 Security: Impelment Secure Erase for Credential memory
dd6723c 
Security credentials could be grabbed from a core dump or memory dump and used
later if not freed securely. Implement a secure erase of the memory used for
the security credential.

Signed-off-by: David Quigley <david.quigley@intel.com>
daosbuild1
daosbuild1 previously requested changes Feb 18, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-4690/1/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4690/1/execution/node/68/log

@dpquigl
checkpatch warnings
cbc2afa 
Signed-off-by: David Quigley <david.quigley@intel.com>
@daosbuild1 daosbuild1 dismissed their stale review February 18, 2021 17:05

Updated patch

daosbuild1
daosbuild1 reviewed Feb 18, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4690/2/execution/node/344/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4690/2/execution/node/307/log

@dpquigl
checkpatch warnings
4eddc3e 
Signed-off-by: David Quigley <david.quigley@intel.com>
daosbuild1
daosbuild1 previously requested changes Feb 18, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-4690/3/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4690/3/execution/node/69/log

@daosbuild1
Copy link
Collaborator

Test stage Unit Test completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4690/3/execution/node/725/log

@daosbuild1
Copy link
Collaborator

Test stage Unit Test with memcheck completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4690/3/execution/node/711/log

@daosbuild1 daosbuild1 dismissed their stale review February 19, 2021 15:36

Updated patch

daosbuild1
daosbuild1 previously requested changes Feb 19, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-4690/4/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4690/4/execution/node/72/log

@daosbuild1
Copy link
Collaborator

Test stage Unit Test completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4690/4/execution/node/801/log

@daosbuild1
Copy link
Collaborator

Test stage Unit Test with memcheck completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4690/4/execution/node/815/log

@dpquigl
Fix tests and check for empty verifier
01db84c 
Signed-off-by: David Quigley <david.quigley@intel.com>
@daosbuild1 daosbuild1 dismissed their stale review February 19, 2021 23:15

Updated patch

daosbuild1
daosbuild1 previously requested changes Feb 19, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-4690/5/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4690/5/execution/node/72/log

@daosbuild1 daosbuild1 dismissed their stale review February 22, 2021 17:23

Updated patch

daosbuild1
daosbuild1 previously requested changes Feb 22, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-4690/6/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4690/6/execution/node/72/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4690/6/execution/node/351/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4690/6/execution/node/405/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4690/6/execution/node/309/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4690/9/execution/node/358/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4690/9/execution/node/355/log

@daosbuild1
Copy link
Collaborator

Test stage Build on Ubuntu 20.04 with Clang completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4690/9/execution/node/557/log

@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4690/9/execution/node/421/log

@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4690/9/execution/node/572/log

@dpquigl
Reverse check
28e2394 
Signed-off-by: David Quigley <david.quigley@intel.com>
@daosbuild1 daosbuild1 dismissed their stale review March 5, 2021 05:22

Updated patch

daosbuild1
daosbuild1 previously requested changes Mar 5, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-4690/10/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4690/10/execution/node/72/log

@daosbuild1
Copy link
Collaborator

Test stage Scan CentOS 7 RPMs completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4690/10/execution/node/1143/log

kjacque
kjacque previously approved these changes Mar 5, 2021
View reviewed changes
jbrosenz
jbrosenz previously approved these changes Mar 5, 2021
View reviewed changes
@dpquigl
Fix checkpatch warnings
f2adefd 
Signed-off-by: David Quigley <david.quigley@intel.com>
@dpquigl dpquigl dismissed stale reviews from jbrosenz and kjacque via f2adefd March 5, 2021 23:16
@daosbuild1 daosbuild1 dismissed their stale review March 5, 2021 23:18

Updated patch

daosbuild1
daosbuild1 reviewed Mar 5, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

daosbuild1
daosbuild1 reviewed Mar 8, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

jbrosenz
jbrosenz approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@jbrosenz jbrosenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjmac mjmac merged commit 7e5e1e7 into master Mar 10, 2021
@mjmac mjmac deleted the dpquigl/DAOS-6801 branch March 10, 2021 21:25
dpquigl added a commit that referenced this pull request Mar 11, 2021
@dpquigl
DAOS-6801 Security: Implement Secure Erase for Credential memory (#4690)
cc2e173 
Security credentials could be grabbed from a core dump or memory dump and used
later if not freed securely. Implement a secure erase of the memory used for
the security credential.

Master-PR: #4690

Signed-off-by: David Quigley <david.quigley@intel.com>
@dpquigl dpquigl mentioned this pull request Mar 11, 2021
Merged
jolivier23 pushed a commit that referenced this pull request Mar 15, 2021
@dpquigl
DAOS-6801 Security: Implement Secure Erase for Credential memory (#4690…
2daceeb 
…) (#4963)

Security credentials could be grabbed from a core dump or memory dump and used
later if not freed securely. Implement a secure erase of the memory used for
the security credential.

Master-PR: #4690

Signed-off-by: David Quigley <david.quigley@intel.com>
@ashleypittman ashleypittman mentioned this pull request Apr 28, 2021
Closed
@ashleypittman ashleypittman mentioned this pull request May 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@kjacque kjacque kjacque approved these changes

@ashleypittman ashleypittman Awaiting requested review from ashleypittman

@johannlombardi johannlombardi Awaiting requested review from johannlombardi

+1 more reviewer

@jbrosenz jbrosenz jbrosenz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dpquigl @daosbuild1 @kjacque @johannlombardi @jbrosenz @mjmac