Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.2 dfuse single #5582

Closed
wants to merge 1 commit into from
Closed

1.2 dfuse single #5582

wants to merge 1 commit into from

Conversation

ashleypittman
Copy link
Contributor

@ashleypittman
DAOS-7176 dfuse: Fix single-threaded option to dfuse. (#5575)
c8cde8c 
This got broken with recent changes, so re-instate it and
add a test to verify it's correct.

Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>
@ashleypittman ashleypittman changed the base branch from master to release/1.2 April 28, 2021 07:11
daosbuild1
daosbuild1 reviewed Apr 28, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

FYI: Errors found in lines not modified in the patch:

utils/node_local_test.py:37:
(pylint-unnecessary-pass) Unnecessary pass statement

utils/node_local_test.py:41:
(pylint-unnecessary-pass) Unnecessary pass statement

utils/node_local_test.py:52:
(pylint-unnecessary-pass) Unnecessary pass statement

utils/node_local_test.py:68:
(pylint-subprocess-run-check) Using subprocess.run without explicitly set check is not recommended.

utils/node_local_test.py:416:
(pylint-implicit-str-concat) Implicit string concatenation found in list

utils/node_local_test.py:513:
(pylint-inconsistent-return-statements) Either all return statements in a function should return an expression, or none of them should.

utils/node_local_test.py:595:
(pylint-subprocess-run-check) Using subprocess.run without explicitly set check is not recommended.

utils/node_local_test.py:617:
(pylint-subprocess-run-check) Using subprocess.run without explicitly set check is not recommended.

utils/node_local_test.py:958:
(pylint-subprocess-run-check) Using subprocess.run without explicitly set check is not recommended.

utils/node_local_test.py:1404:
(pylint-subprocess-run-check) Using subprocess.run without explicitly set check is not recommended.

utils/node_local_test.py:1628:
(pylint-subprocess-run-check) Using subprocess.run without explicitly set check is not recommended.

utils/node_local_test.py:1653:
(pylint-subprocess-run-check) Using subprocess.run without explicitly set check is not recommended.

utils/node_local_test.py:1748:
(pylint-subprocess-run-check) Using subprocess.run without explicitly set check is not recommended.

utils/node_local_test.py:1749:
(pylint-subprocess-run-check) Using subprocess.run without explicitly set check is not recommended.

utils/node_local_test.py:1762:
(pylint-unused-variable) Unused variable 'uns_container'

utils/node_local_test.py:2004:
(pylint-subprocess-run-check) Using subprocess.run without explicitly set check is not recommended.

utils/node_local_test.py:2013:
(pylint-subprocess-run-check) Using subprocess.run without explicitly set check is not recommended.

utils/node_local_test.py:2023:
(pylint-subprocess-run-check) Using subprocess.run without explicitly set check is not recommended.

utils/node_local_test.py:2034:
(pylint-subprocess-run-check) Using subprocess.run without explicitly set check is not recommended.

utils/node_local_test.py:2051:
(pylint-subprocess-run-check) Using subprocess.run without explicitly set check is not recommended.

utils/node_local_test.py:2057:
(pylint-subprocess-run-check) Using subprocess.run without explicitly set check is not recommended.

@ashleypittman
Copy link
Contributor Author

Replaced by #5660 as this PR hit some github issues.

@ashleypittman ashleypittman deleted the 1.2-dfuse-single branch May 6, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashleypittman @daosbuild1