-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-7123 dfuse: Fix coverity issues arising from recent changes. #5335
Conversation
Improve error handling and freeing resources correctly. Most of these changes are the result of the pool-connect rewrite and were found by coverity. Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
D_FREE(ie); | ||
out: | ||
if (rc == ENOENT && parent->ie_dfs->dfs_attr_timeout > 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This particular part is re-written as part of #4540 anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
) Improve error handling and freeing resources correctly. Most of these changes are the result of the pool-connect rewrite and were found by coverity. Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com> Co-authored-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com> Conflicts: src/client/dfuse/ops/lookup.c
) (#5477) Improve error handling and freeing resources correctly. Most of these changes are the result of the pool-connect rewrite and were found by coverity. Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com> Co-authored-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
No description provided.