Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-7123 dfuse: Fix coverity issues arising from recent changes. #5335

Merged
merged 5 commits into from
Apr 16, 2021

Conversation

ashleypittman
Copy link
Contributor

No description provided.

Improve error handling and freeing resources correctly.

Most of these changes are the result of the pool-connect rewrite
and were found by coverity.

Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

D_FREE(ie);
out:
if (rc == ENOENT && parent->ie_dfs->dfs_attr_timeout > 0) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This particular part is re-written as part of #4540 anyway.

@ashleypittman ashleypittman requested a review from dpquigl April 8, 2021 14:22
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@jolivier23 jolivier23 changed the title DAOS-7123 dfuse: Fix coverity issues arrising from recent changes. DAOS-7123 dfuse: Fix coverity issues arising from recent changes. Apr 16, 2021
@jolivier23 jolivier23 merged commit 93add90 into master Apr 16, 2021
@jolivier23 jolivier23 deleted the dfuse-cov branch April 16, 2021 12:56
mchaarawi pushed a commit that referenced this pull request Apr 16, 2021
)

Improve error handling and freeing resources correctly.

Most of these changes are the result of the pool-connect rewrite
and were found by coverity.

Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>
Co-authored-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
Conflicts:
	src/client/dfuse/ops/lookup.c
dpquigl pushed a commit that referenced this pull request Apr 16, 2021
)

Improve error handling and freeing resources correctly.

Most of these changes are the result of the pool-connect rewrite
and were found by coverity.

Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>
Co-authored-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
sylviachanoiyee pushed a commit that referenced this pull request Apr 22, 2021
) (#5477)

Improve error handling and freeing resources correctly.

Most of these changes are the result of the pool-connect rewrite
and were found by coverity.

Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>
Co-authored-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
@ashleypittman ashleypittman mentioned this pull request Apr 28, 2021
@ashleypittman ashleypittman mentioned this pull request May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants