-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-7123 dfuse: Fix coverity issues arising from recent changes. (#5335) #5477
Conversation
) Improve error handling and freeing resources correctly. Most of these changes are the result of the pool-connect rewrite and were found by coverity. Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com> Co-authored-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com> Conflicts: src/client/dfuse/ops/lookup.c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5477/2/execution/node/292/log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Test stage Functional on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5477/6/execution/node/368/log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Improve error handling and freeing resources correctly.
Most of these changes are the result of the pool-connect rewrite
and were found by coverity.
Signed-off-by: Ashley Pittman ashley.m.pittman@intel.com
Co-authored-by: Mohamad Chaarawi mohamad.chaarawi@intel.com
Conflicts:
src/client/dfuse/ops/lookup.c