Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-7123 dfuse: Fix coverity issues arising from recent changes. (#5335) #5477

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

mchaarawi
Copy link
Contributor

Improve error handling and freeing resources correctly.

Most of these changes are the result of the pool-connect rewrite
and were found by coverity.

Signed-off-by: Ashley Pittman ashley.m.pittman@intel.com
Co-authored-by: Mohamad Chaarawi mohamad.chaarawi@intel.com
Conflicts:
src/client/dfuse/ops/lookup.c

)

Improve error handling and freeing resources correctly.

Most of these changes are the result of the pool-connect rewrite
and were found by coverity.

Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>
Co-authored-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
Conflicts:
	src/client/dfuse/ops/lookup.c
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@dpquigl dpquigl added the ast-fixes Fixes associated with issues identified by Application Security Testing Tools label Apr 16, 2021
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5477/2/execution/node/292/log

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5477/6/execution/node/368/log

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@mchaarawi mchaarawi requested a review from a team April 22, 2021 00:34
@sylviachanoiyee sylviachanoiyee merged commit b1aac3f into release/1.2 Apr 22, 2021
@sylviachanoiyee sylviachanoiyee deleted the cov/7123 branch April 22, 2021 01:25
@ashleypittman ashleypittman mentioned this pull request Apr 28, 2021
@ashleypittman ashleypittman mentioned this pull request May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ast-fixes Fixes associated with issues identified by Application Security Testing Tools
Development

Successfully merging this pull request may close these issues.

5 participants