DAOS-7238 test: another check of pool create svc_reps length #5558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-pick solution from a master-based branch. As part of dmg_pool_create() flow, following successful execution of the dmg pool create command, it is expected that the svc_reps returned by dmg shall be of length > 0. Coverity CID 313058 reports that a length of 0 would result in freeing of outpool->svc and a later use after free. A fix was attempted in commit 353e115, adding a check in parse_pool_info(). With this change, another check is made within dmg_pool_create() closer to the d_rank_list_copy() call that would free outpool->svc in this (believed to be theoretical) condition. Signed-off-by: Kenneth Cain <kenneth.c.cain@intel.com>
daosbuild1
reviewed
Apr 24, 2021
dpquigl
approved these changes
Apr 26, 2021
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick solution from a master-based branch.
As part of dmg_pool_create() flow, following successful execution
of the dmg pool create command, it is expected that the svc_reps
returned by dmg shall be of length > 0. Coverity CID 313058 reports
that a length of 0 would result in freeing of outpool->svc and a later
use after free. A fix was attempted in commit 353e115, adding a check
in parse_pool_info(). With this change, another check is made within
dmg_pool_create() closer to the d_rank_list_copy() call that would
free outpool->svc in this (believed to be theoretical) condition.
Signed-off-by: Kenneth Cain kenneth.c.cain@intel.com