-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-3105 control: Scrub engine environment #4968
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Test stage Unit Test with memcheck completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4968/1/execution/node/769/log |
Test stage Scan CentOS 7 RPMs completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4968/1/execution/node/1157/log |
By default, all environment variables provided to the engine subprocesses must be set by the control plane. An optional per-engine config parameter (env_pass_through) may be set to pass through variables set before the control plane was started. Now the engine scrubs the environment by default configure NLT to set all env vars via the config file. Master-PR: #5038 Signed-off-by: Michael MacDonald <mjmac.macdonald@intel.com> Co-authored-by: Ashley Pittman <ashley.m.pittman@intel.com>
23a8b34
to
0282000
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
FYI: Errors found in lines not modified in the patch:
utils/node_local_test.py:37:
(pylint-unnecessary-pass) Unnecessary pass statement
utils/node_local_test.py:41:
(pylint-unnecessary-pass) Unnecessary pass statement
utils/node_local_test.py:52:
(pylint-unnecessary-pass) Unnecessary pass statement
utils/node_local_test.py:68:
(pylint-subprocess-run-check) Using subprocess.run without explicitly set check
is not recommended.
utils/node_local_test.py:416:
(pylint-implicit-str-concat) Implicit string concatenation found in list
utils/node_local_test.py:475:
(pylint-inconsistent-return-statements) Either all return statements in a function should return an expression, or none of them should.
utils/node_local_test.py:557:
(pylint-subprocess-run-check) Using subprocess.run without explicitly set check
is not recommended.
utils/node_local_test.py:579:
(pylint-subprocess-run-check) Using subprocess.run without explicitly set check
is not recommended.
utils/node_local_test.py:922:
(pylint-subprocess-run-check) Using subprocess.run without explicitly set check
is not recommended.
utils/node_local_test.py:1315:
(pylint-subprocess-run-check) Using subprocess.run without explicitly set check
is not recommended.
utils/node_local_test.py:1539:
(pylint-subprocess-run-check) Using subprocess.run without explicitly set check
is not recommended.
utils/node_local_test.py:1564:
(pylint-subprocess-run-check) Using subprocess.run without explicitly set check
is not recommended.
utils/node_local_test.py:1659:
(pylint-subprocess-run-check) Using subprocess.run without explicitly set check
is not recommended.
utils/node_local_test.py:1660:
(pylint-subprocess-run-check) Using subprocess.run without explicitly set check
is not recommended.
utils/node_local_test.py:1673:
(pylint-unused-variable) Unused variable 'uns_container'
utils/node_local_test.py:1915:
(pylint-subprocess-run-check) Using subprocess.run without explicitly set check
is not recommended.
utils/node_local_test.py:1924:
(pylint-subprocess-run-check) Using subprocess.run without explicitly set check
is not recommended.
utils/node_local_test.py:1934:
(pylint-subprocess-run-check) Using subprocess.run without explicitly set check
is not recommended.
utils/node_local_test.py:1945:
(pylint-subprocess-run-check) Using subprocess.run without explicitly set check
is not recommended.
utils/node_local_test.py:1962:
(pylint-subprocess-run-check) Using subprocess.run without explicitly set check
is not recommended.
utils/node_local_test.py:1968:
(pylint-subprocess-run-check) Using subprocess.run without explicitly set check
is not recommended.
By default, all environment variables provided to the
engine subprocesses must be set by the control plane.
An optional per-engine config parameter (env_pass_through)
may be set to pass through variables set before the control
plane was started.
Master-PR: #4947