Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-5737 tests: Removing oclass param from create_cont() (#4729) #4853

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

saurabhtandan
Copy link
Contributor

Removing oclass param from create_cont() inside
ftest/util/ior_test_base.py as it is breaking some
of the weekly tests.
The change was earlier added to the code for datamover
tests which now use an overriden version of this method.

Hence 'oclass' param is not needed anymore andn ot used
anywhere else.

Test-tag-hw-small: pr,hw,small dfusespacecheck ioaggregation dfusesparsefile
Test-tag-hw-large: pr,hw,large multicontainerdelete

Signed-off-by: Saurabh Tandan saurabh.tandan@intel.com

Removing oclass param from create_cont() inside
ftest/util/ior_test_base.py as it is breaking some
of the weekly tests.
The change was earlier added to the code for datamover
tests which now use an overriden version of this method.

Hence 'oclass' param is not needed anymore andn ot used
anywhere else.

Test-tag-hw-small: pr,hw,small dfusespacecheck ioaggregation dfusesparsefile
Test-tag-hw-large: pr,hw,large multicontainerdelete

Signed-off-by: Saurabh Tandan <saurabh.tandan@intel.com>
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

FYI: Errors found in lines not modified in the patch:

src/tests/ftest/container/multiple_container_delete.py:58:
(pylint-logging-format-interpolation) Use lazy % formatting in logging functions

src/tests/ftest/container/multiple_container_delete.py:64:
(pylint-logging-format-interpolation) Use lazy % formatting in logging functions

src/tests/ftest/container/multiple_container_delete.py:68:
(pylint-logging-format-interpolation) Use lazy % formatting in logging functions

src/tests/ftest/container/multiple_container_delete.py:82:
(pylint-no-else-return) Unnecessary "else" after "return"

src/tests/ftest/util/ior_test_base.py:36:
(pylint-super-with-arguments) Consider using Python 3 style super() without arguments

src/tests/ftest/util/ior_test_base.py:48:
(pylint-super-with-arguments) Consider using Python 3 style super() without arguments

src/tests/ftest/util/ior_test_base.py:97:
(pylint-too-many-arguments) Too many arguments (11/10)

@daosbuild1
Copy link
Collaborator

Test stage Scan CentOS 7 RPMs completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4853/1/execution/node/1141/log

@daosbuild1
Copy link
Collaborator

Test stage Functional_Hardware_Small completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4853/1/execution/node/1252/log

@saurabhtandan
Copy link
Contributor Author

Failing issues are unrelated to the changes made in this pr.
LLNL/romio: DAOS-6905
PoolCreateTest: DAOS-6784
ErasureCodeIor: DAOS-6788

@saurabhtandan saurabhtandan requested a review from a team March 8, 2021 22:22
@sylviachanoiyee sylviachanoiyee merged commit dba8c93 into release/1.2 Mar 10, 2021
@sylviachanoiyee sylviachanoiyee deleted the DAOS-5737_1.2 branch March 10, 2021 18:25
@ashleypittman ashleypittman mentioned this pull request Apr 28, 2021
@ashleypittman ashleypittman mentioned this pull request May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants