DAOS-7229 build: Remove client dependence on server libraries #5445
Conversation
|
Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5445/1/execution/node/328/log |
jolivier23
force-pushed
the
jvolivie/storage
branch
from
32c9654 to
58a7fe8
Compare
|
Test stage Unit Test completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-5445/1/display/redirect |
|
Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5445/2/execution/node/352/log |
jolivier23
force-pushed
the
jvolivie/storage
branch
from
58a7fe8 to
059ab97
Compare
|
Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5445/3/execution/node/365/log |
jolivier23
force-pushed
the
jvolivie/storage
branch
from
059ab97 to
7a31c4d
Compare
|
Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5445/4/execution/node/365/log |
Client package currently installs PMDK and SPDK which we do not want. Changes in this patch: 1. Move storage_estimator to VOS 2. Replace libdaos_common_pmem in daos_test with libdaos_common 3. Move io_conf (VOS only) to server package 4. Move libvos_size.so to daos_srv 5. Remove daos_common_pemem dependence from daos utility 6. Remove rdbt from common package 7. Remove libdaos_tests and various utilities from common package 8. Modify daos.spec to move files around Signed-off-by: Jeff Olivier <jeffrey.v.olivier@intel.com>
jolivier23
force-pushed
the
jvolivie/storage
branch
from
7a31c4d to
780a1ed
Compare
jolivier23
changed the title
|
Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5445/5/execution/node/372/log |
Signed-off-by: Jeff Olivier <jeffrey.v.olivier@intel.com>
There was a problem hiding this comment.
The changes look good, but since this is something that can very easily regress, it would be great to add a regression test at
Lines 4 to 5 in 41a9950
If you are going to add that, could you also include this change (I've included the regression test(s); I'm assuming that daos-server should not depend on daos-client; you can remove the second regression test if that is not a valid assumption):
-sudo yum -y install --exclude ompi daos{,-client}-"${DAOS_PKG_VERSION}"
-sudo yum -y history rollback last-1
-sudo yum -y install --exclude ompi daos{,-{server,client}}-"${DAOS_PKG_VERSION}"
-sudo yum -y install --exclude ompi daos{,-tests}-"${DAOS_PKG_VERSION}"
+sudo yum -y install --exclude ompi daos-client-"${DAOS_PKG_VERSION}"
+if rpm -q daos-server; then
+ echo "daos-server RPM should not be installed as a dependency of daos-client"
+ exit 1
+fi
+sudo yum -y history rollback last-1
+sudo yum -y install --exclude ompi daos-server-"${DAOS_PKG_VERSION}"
+if rpm -q daos-server; then
+ echo "daos-client RPM should not be installed as a dependency of daos-server"
+ exit 1
+fi
+sudo yum -y install --exclude ompi daos-tests-"${DAOS_PKG_VERSION}"We also should not be papering over possible daos-{server,client} and daos dependency issues by forcing the install of the latter with the former.
Signed-off-by: Jeff Olivier <jeffrey.v.olivier@intel.com>
jolivier23
dismissed stale reviews from brianjmurrell and johannlombardi
via
9756f27
|
Test stage Test CentOS 7 RPMs completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5445/8/execution/node/1085/log |
Signed-off-by: Jeff Olivier <jeffrey.v.olivier@intel.com>
Signed-off-by: Jeff Olivier <jeffrey.v.olivier@intel.com>
Signed-off-by: Jeff Olivier <jeffrey.v.olivier@intel.com>
|
Test stage NLT completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-5445/10/display/redirect |
Signed-off-by: Jeff Olivier <jeffrey.v.olivier@intel.com>
Client package currently installs PMDK and SPDK which we do not want. Changes in this patch: 1. Move storage_estimator to VOS 2. Replace libdaos_common_pmem in daos_test with libdaos_common 3. Move io_conf (VOS only) to server package 4. Move libvos_size.so to daos_srv 5. Remove daos_common_pemem dependence from daos utility 6. Remove rdbt from common package 7. Remove libdaos_tests and various utilities from common package 8. Modify daos.spec to move files around Note that daos-tests now depends on daos-server. We will need to do some further changes to remove this dependence. But at least there is no dependence between daos-server and daos-client Signed-off-by: Jeff Olivier <jeffrey.v.olivier@intel.com>
Client package currently installs PMDK and SPDK which we do not
want. Changes in this patch:
Signed-off-by: Jeff Olivier jeffrey.v.olivier@intel.com