Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-623 build: Do not try and install the python3 package #5127

Merged
merged 1 commit into from
Mar 23, 2021
Merged

DAOS-623 build: Do not try and install the python3 package #5127

merged 1 commit into from
Mar 23, 2021

Conversation

ashleypittman
Copy link
Contributor

Signed-off-by: Ashley Pittman ashley.m.pittman@intel.com

daosbuild1
daosbuild1 reviewed Mar 23, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

daosbuild1
daosbuild1 reviewed Mar 23, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@ashleypittman
DAOS-623 build: Do not try and install the python3 package
8cb13eb 
The package is already installed, and for some reason dnf
takes a long time to establist this.

Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>
daosbuild1
daosbuild1 reviewed Mar 23, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

daosbuild1
daosbuild1 reviewed Mar 23, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@ashleypittman ashleypittman changed the title Do not install the python 3 pakcage. Do not install the python 3 package. Mar 23, 2021
@ashleypittman ashleypittman changed the title Do not install the python 3 package. DAOS-623 build: Do not try and install the python3 package Mar 23, 2021
brianjmurrell
brianjmurrell approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@brianjmurrell brianjmurrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think we need to understand why such a NOOP takes so long otherwise this is going to come back and bite us again.

It really smells like a bug to me.

@jolivier23 jolivier23 merged commit 97f8e5e into master Mar 23, 2021
@jolivier23 jolivier23 deleted the skip-python3-install branch March 23, 2021 22:42
jolivier23 pushed a commit that referenced this pull request Mar 23, 2021
@ashleypittman @jolivier23
DAOS-623 build: Do not try and install the python3 package (#5127)
38fdb52 
The package is already installed, and for some reason dnf
takes a long time to establist this.

Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>
johannlombardi pushed a commit that referenced this pull request Mar 24, 2021
@jolivier23
DAOS-623 build: Do not try and install the python3 package (#5127) (#…
937582b 
…5138)

The package is already installed, and for some reason dnf
takes a long time to establist this.

Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>
@ashleypittman ashleypittman mentioned this pull request Apr 28, 2021
Closed
@ashleypittman ashleypittman mentioned this pull request May 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@jolivier23 jolivier23 jolivier23 approved these changes

@brianjmurrell brianjmurrell brianjmurrell approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashleypittman @brianjmurrell @jolivier23 @daosbuild1