Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-6903 Test: Fix regression in NVMe health test code. (#4832) #5240

Merged
merged 1 commit into from
Apr 2, 2021
Merged

DAOS-6903 Test: Fix regression in NVMe health test code. (#4832) #5240

merged 1 commit into from
Apr 2, 2021

Conversation

ravalsam
Copy link
Contributor

Quick-Functional: true
Test-tag: csum_error_log nvme_health der_enospace

Signed-off-by: Samir Raval samir.raval@intel.com

@ravalsam
Copy link
Contributor Author

Ci Test result can be found from https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-5240/1/artifact/Functional_Hardware_Medium/nvme/

mjean308
mjean308 previously approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@mjean308 mjean308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

saurabhtandan
saurabhtandan previously approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@saurabhtandan saurabhtandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ravalsam ravalsam requested a review from a team March 31, 2021 23:45
@sylviachanoiyee
Copy link
Contributor

@ravalsam , can we run all func tests? you can skip unit testing
I don't see result for nvme_io and there is change in the general utils.

@ravalsam
Copy link
Contributor Author

ravalsam commented Apr 1, 2021

@ravalsam , can we run all func tests? you can skip unit testing
I don't see result for nvme_io and there is change in the general utils.

I was mention not to run all tests when we Cherry-pick instead only which impacts the tests. is that changed now?

NVMe IO has been worked out in another PR because of getting issue in the DAOS side and that was the reason I did not ran part of Ci in this PR.

DAOS-6903 Test: Fix regression in NVMe health test code. (#4832)
dbed2f0 
Signed-off-by: Samir Raval <samir.raval@intel.com>
@ravalsam ravalsam dismissed stale reviews from saurabhtandan and mjean308 via dbed2f0 April 1, 2021 14:09
@ravalsam ravalsam force-pushed the samirrav/DAOS-6903-1.2 branch from 4c5de4e to dbed2f0 Compare April 1, 2021 14:09
daosbuild1
daosbuild1 reviewed Apr 1, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

dinghwah
dinghwah approved these changes Apr 2, 2021
View reviewed changes
Copy link
Contributor

@dinghwah dinghwah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

saurabhtandan
saurabhtandan approved these changes Apr 2, 2021
View reviewed changes
Copy link
Contributor

@saurabhtandan saurabhtandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sylviachanoiyee sylviachanoiyee merged commit 32b661f into release/1.2 Apr 2, 2021
@sylviachanoiyee sylviachanoiyee deleted the samirrav/DAOS-6903-1.2 branch April 2, 2021 19:52
@ashleypittman ashleypittman mentioned this pull request Apr 28, 2021
Closed
@ashleypittman ashleypittman mentioned this pull request May 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@saurabhtandan saurabhtandan saurabhtandan approved these changes

@dinghwah dinghwah dinghwah approved these changes

@rpadma2 rpadma2 Awaiting requested review from rpadma2

@mjean308 mjean308 Awaiting requested review from mjean308

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ravalsam @sylviachanoiyee @saurabhtandan @daosbuild1 @dinghwah @mjean308