DAOS-6798 iv: stop the iv ns leader first during destroy #4886
Conversation
Cherry-pick of PR #4827 from daos master to daos release/1.2. Let's stop the iv ns leader during the destory first, so all arriving IV requests will fail and return immediately. And with this change the mdtest_small test is re-enabled for PRs. Signed-off-by: Di Wang <di.wang@intel.com> Signed-off-by: Kenneth Cain <kenneth.c.cain@intel.com>
kccain
force-pushed
the
kccain/daos_6798_rel1p2
branch
from
80eb3cb to
7842fbf
Compare
|
The pool create test failures from build 1 are known to have been just recently fixed on release/1.2 branch. I have rebased this branch on latest release/1.2 and pushed for another round of CI testing to get rid of those issues. |
|
Test stage Scan CentOS 7 RPMs completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4886/2/execution/node/1181/log |
|
the other rebuild0-10 test failure in build 1 is due to an existing bug that requires its fix to be landed to release/1.2 branch build 2 failures are due to existing bugs
build 2 also showing a failure in Scan CentOS 7 RPMs that seems to be happening on other release/1.2 PRs e.g., PR 4589 and has been a recent issue on master. |
|
I will wait for landing of PR #4881 to master that re-enables mdtest_small there, before requesting landing of this change to release/1.2 branch. This PR being an unmodified cherry-pick of master PR 4827 + PR 4881 will not require code reviews on this release/1.2 PR. I will request landing from gatekeeper. |
|
OK this is ready for review by @daos-stack/daos-gatekeeper . |
| @@ -4805,6 +4805,7 @@ ds_pool_evict_handler(crt_rpc_t *rpc) | |||
| D_GOTO(out_free, rc); | |||
|
|
|||
| ds_pool_iv_srv_hdl_invalidate(svc->ps_pool); | |||
| ds_iv_ns_leader_stop(svc->ps_pool->sp_iv_ns); | |||
There was a problem hiding this comment.
should this be done as first operation before you proceed with tx update and hdl invalidation?
There was a problem hiding this comment.
oh, we want server handle be invalidated successfully during pool destroy, otherwise if iv_ns_leader_stop is being executed first, server handle invalidation will fail.
|
https://jira.hpdd.intel.com/browse/DAOS-6798 has just been marked approved to merge for release 1.2. |
Cherry-pick of PR #4827 from daos master to daos release/1.2.
Let's stop the iv ns leader during the destory first, so
all arriving IV requests will fail and return immediately.
And with this change the mdtest_small test is re-enabled for PRs.
Signed-off-by: Di Wang di.wang@intel.com
Signed-off-by: Kenneth Cain kenneth.c.cain@intel.com