Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-7102 DFS: fix naming between NAME and PATH max values #5190

Merged
merged 2 commits into from
Mar 28, 2021
Merged

DAOS-7102 DFS: fix naming between NAME and PATH max values #5190

merged 2 commits into from
Mar 28, 2021

Conversation

mchaarawi
Copy link
Contributor

Signed-off-by: Mohamad Chaarawi mohamad.chaarawi@intel.com

daosbuild1
daosbuild1 reviewed Mar 25, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@mchaarawi mchaarawi changed the title DAOS-625 DFS: correct name of max len instead of path DAOS-623 DFS: correct name of max len instead of path Mar 25, 2021
@mchaarawi
DAOS-625 DFS: correct name of max len instead of path
671576e 
Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
@mchaarawi mchaarawi force-pushed the mschaara/name_len_fix branch from 3afa620 to 671576e Compare March 25, 2021 21:28
daosbuild1
daosbuild1 reviewed Mar 25, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

daltonbohning
daltonbohning approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems straightforward

@mchaarawi mchaarawi changed the title DAOS-623 DFS: correct name of max len instead of path DAOS-7102 DFS: fix naming between NAME and PATH max values Mar 25, 2021
@daltonbohning daltonbohning mentioned this pull request Mar 25, 2021
Merged
@daosbuild1
Copy link
Collaborator

Test stage Unit Test with memcheck completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5190/2/execution/node/874/log

daosbuild1
daosbuild1 reviewed Mar 26, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@mchaarawi mchaarawi requested a review from dsikich March 26, 2021 13:24
dsikich
dsikich approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@dsikich dsikich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mchaarawi mchaarawi requested a review from a team March 26, 2021 18:55
@johannlombardi johannlombardi merged commit f357124 into master Mar 28, 2021
@johannlombardi johannlombardi deleted the mschaara/name_len_fix branch March 28, 2021 09:04
mchaarawi added a commit that referenced this pull request Mar 29, 2021
@mchaarawi
DAOS-7102 DFS: correct name of max len instead of path (#5190)
055019f 
Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
sylviachanoiyee pushed a commit that referenced this pull request Mar 30, 2021
@mchaarawi
DAOS-7102 DFS: correct name of max len instead of path (#5190) (#5215)
bd73234 
correct name of max len instead of path 

Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
@ashleypittman ashleypittman mentioned this pull request Apr 28, 2021
Closed
@ashleypittman ashleypittman mentioned this pull request May 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@dsikich dsikich dsikich approved these changes

@daltonbohning daltonbohning daltonbohning approved these changes

@ashleypittman ashleypittman Awaiting requested review from ashleypittman

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mchaarawi @daosbuild1 @daltonbohning @dsikich @johannlombardi