Skip to content

DAOS-6376 container: Get Props with Open Container Handle #5114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 30, 2021

Conversation

ryon-jensen
Copy link
Contributor

In the server, on a container open, the output properties are set
based on requested prop bits. This was being skipped when the
container handle was already open. This patch moves where the
requested props are read so they will always be set.

From master

Signed-off-by: Ryon Jensen ryon.jensen@intel.com

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@ryon-jensen ryon-jensen force-pushed the ryon-jensen/1.2/ContPropFix_DAOS-6376 branch from 1da0747 to 74a15fd Compare March 22, 2021 16:54
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

jolivier23
jolivier23 previously approved these changes Mar 22, 2021
@daosbuild1
Copy link
Collaborator

Test stage Functional on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-5114/2/display/redirect

@daosbuild1
Copy link
Collaborator

Test stage Functional on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-5114/2/display/redirect

NiuYawei
NiuYawei previously approved these changes Mar 23, 2021
In the server, on a container open, the output properties are set
based on requested prop bits. This was being skipped when the
container handle was already open. This patch moves where the
requested props are read so they will always be set.

Signed-off-by: Ryon Jensen <ryon.jensen@intel.com>
@ryon-jensen ryon-jensen dismissed stale reviews from NiuYawei and jolivier23 via 8627300 March 24, 2021 14:28
@ryon-jensen ryon-jensen force-pushed the ryon-jensen/1.2/ContPropFix_DAOS-6376 branch from 74a15fd to 8627300 Compare March 24, 2021 14:28
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@ryon-jensen ryon-jensen requested a review from a team March 30, 2021 15:17
@jolivier23 jolivier23 merged commit 5ca67c9 into release/1.2 Mar 30, 2021
@jolivier23 jolivier23 deleted the ryon-jensen/1.2/ContPropFix_DAOS-6376 branch March 30, 2021 20:59
@ashleypittman ashleypittman mentioned this pull request Apr 28, 2021
@ashleypittman ashleypittman mentioned this pull request May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants