-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-6753 test: Reenable skipped test: delete_objects.py #5171
Conversation
Test-tag-hw-large: pr,hw,large rebuilddeleterecord Signed-off-by: Maureen Jean <maureen.jean@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Test-tag-hw-large: pr,hw,large rebuilddeleterecord Signed-off-by: Maureen Jean <maureen.jean@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Test-tag-hw-large: pr,hw,large rebuilddeleterecord Signed-off-by: Maureen Jean <maureen.jean@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Test-tag-hw-large: pr,hw,large rebuilddeleterecord Signed-off-by: Maureen Jean <maureen.jean@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
@@ -35,5 +35,5 @@ container: | |||
record_qty: 1 | |||
debug: True | |||
rebuild: | |||
rank: 4 | |||
rank: 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the existing rank 4 is being skipped/cancelled due to an existing issue, maybe the right thing to do here is to add a variant to run with rank 3, not replace. I think this would help avoid confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since DAOS-6865 has merged there is no reason to use rank 3 now.
Test-tag-hw-large: pr,hw,large rebuilddeleterecord Signed-off-by: Maureen Jean <maureen.jean@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Test-tag-hw-large: pr,hw,large rebuilddeleterecord rebuilddeleteobject
Test-tag-hw-large: pr,hw,large rebuilddeleterecord rebuilddeleteobject Signed-off-by: Maureen Jean <maureen.jean@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Test-tag-hw-large: pr,hw,large rebuilddeleterecord rebuilddeleteobject
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Test-tag: delete_objects Signed-off-by: Maureen Jean <maureen.jean@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Test-tag-vm: pr,-hw rebuilddeleterecord rebuilddeleteobject
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code wise LGTM. But seems like one variant of delete_objects.py is failing due to DAOS-7169
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Maureen, could you run all functional tests? |
Test-tag-vm: pr,-hw rebuilddeleterecord rebuilddeleteobject
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Reenable skipped test: delete_objects.py Signed-off-by: Maureen Jean <maureen.jean@intel.com>
Test-tag-hw-large: pr,hw,large rebuilddeleterecord
Signed-off-by: Maureen Jean maureen.jean@intel.com