Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-6753 test: Reenable skipped test: delete_objects.py #5171

Merged
merged 13 commits into from
Apr 9, 2021

Conversation

mjean308
Copy link
Contributor

Test-tag-hw-large: pr,hw,large rebuilddeleterecord

Signed-off-by: Maureen Jean maureen.jean@intel.com

Test-tag-hw-large: pr,hw,large rebuilddeleterecord

Signed-off-by: Maureen Jean <maureen.jean@intel.com>
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

Test-tag-hw-large: pr,hw,large rebuilddeleterecord

Signed-off-by: Maureen Jean <maureen.jean@intel.com>
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

Test-tag-hw-large: pr,hw,large rebuilddeleterecord

Signed-off-by: Maureen Jean <maureen.jean@intel.com>
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

Test-tag-hw-large: pr,hw,large rebuilddeleterecord

Signed-off-by: Maureen Jean <maureen.jean@intel.com>
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@@ -35,5 +35,5 @@ container:
record_qty: 1
debug: True
rebuild:
rank: 4
rank: 3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the existing rank 4 is being skipped/cancelled due to an existing issue, maybe the right thing to do here is to add a variant to run with rank 3, not replace. I think this would help avoid confusion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since DAOS-6865 has merged there is no reason to use rank 3 now.

Test-tag-hw-large: pr,hw,large rebuilddeleterecord

Signed-off-by: Maureen Jean <maureen.jean@intel.com>
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

mjean308 added 2 commits April 1, 2021 09:41
Test-tag-hw-large: pr,hw,large rebuilddeleterecord rebuilddeleteobject
Test-tag-hw-large: pr,hw,large rebuilddeleterecord rebuilddeleteobject

Signed-off-by: Maureen Jean <maureen.jean@intel.com>
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

mjean308 added 2 commits April 2, 2021 07:05
Test-tag-hw-large: pr,hw,large rebuilddeleterecord rebuilddeleteobject
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

mjean308 added 2 commits April 5, 2021 09:24
Test-tag: delete_objects

Signed-off-by: Maureen Jean <maureen.jean@intel.com>
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

Test-tag-vm: pr,-hw rebuilddeleterecord rebuilddeleteobject
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

Copy link
Contributor

@saurabhtandan saurabhtandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise LGTM. But seems like one variant of delete_objects.py is failing due to DAOS-7169

Copy link
Contributor

@dinghwah dinghwah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjean308 mjean308 requested a review from a team April 7, 2021 13:07
@sylviachanoiyee
Copy link
Contributor

Maureen, could you run all functional tests?
You can skip unit test

Test-tag-vm: pr,-hw rebuilddeleterecord rebuilddeleteobject
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@sylviachanoiyee sylviachanoiyee merged commit d8b8ed0 into master Apr 9, 2021
@sylviachanoiyee sylviachanoiyee deleted the DAOS-6753 branch April 9, 2021 15:13
mjean308 added a commit that referenced this pull request Apr 9, 2021
Reenable skipped test: delete_objects.py

Signed-off-by: Maureen Jean <maureen.jean@intel.com>
johannlombardi pushed a commit that referenced this pull request Apr 12, 2021
Reenable skipped test: delete_objects.py

Signed-off-by: Maureen Jean <maureen.jean@intel.com>
@ashleypittman ashleypittman mentioned this pull request Apr 28, 2021
@ashleypittman ashleypittman mentioned this pull request May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants