DAOS-6748 placement: Do not clear used_tgts in get_target (#4751) #4829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not clear used_tgts in get_targets, since we do not want put multiple shards in a single VOS target yet, which could happen when there are different VOS targets in each fault domain. Add dom_occupied to get_targets to represent the domain whose targets has been used up for the objects, so to avoid the domain to be choosen. Do not need rehash within the same rank, if the targets has been used, let's just walk through the targets to find the avaible spots. Signed-off-by: Di Wang <di.wang@intel.com>
daosbuild1
reviewed
Mar 2, 2021
|
Test stage Scan CentOS 7 RPMs completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4829/1/execution/node/1161/log |
byron-marohn
approved these changes
Mar 3, 2021
|
Test stage Functional_Hardware_Large completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-4829/1/display/redirect |
|
This should land ASAP to avoid incompat between master and 1.2. |
liuxuezhao
approved these changes
Mar 5, 2021
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not clear used_tgts in get_targets, since we do not want
put multiple shards in a single VOS target yet, which could
happen when there are different VOS targets in each fault
domain.
Add dom_occupied to get_targets to represent the domain whose
targets has been used up for the objects, so to avoid the
domain to be choosen.
Do not need rehash within the same rank, if the targets has been
used, let's just walk through the targets to find the avaible
spots.
Signed-off-by: Di Wang di.wang@intel.com