DAOS-6926 logging: Do not check for facility used in alloc/free. #4839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cost of keeping the whitelist up to date is greater than the benefit from having the check so simply remove it. Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>
daosbuild1
reviewed
Mar 3, 2021
There was a problem hiding this comment.
LGTM. No errors found by checkpatch.
FYI: Errors found in lines not modified in the patch:
src/tests/ftest/cart/util/cart_logtest.py:332:
(pylint-redefined-outer-name) Redefining name 'pid' from outer scope (line 315)
src/tests/ftest/cart/util/cart_logtest.py:394:
(pylint-chained-comparison) Simplify chained comparison between the operands
Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>
daosbuild1
reviewed
Mar 3, 2021
|
Test stage Scan CentOS 7 RPMs completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4839/2/execution/node/1151/log |
liw
approved these changes
Mar 3, 2021
dmiter
approved these changes
Mar 3, 2021
|
Only test failures are the three pool-create tests and the rpm scan. |
ashleypittman
added a commit
that referenced
this pull request
Mar 16, 2021
The cost of keeping the whitelist up to date is greater than the benefit from having the check so simply remove it. Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>
jolivier23
pushed a commit
that referenced
this pull request
Mar 18, 2021
…) (#5030) The cost of keeping the whitelist up to date is greater than the benefit from having the check so simply remove it. Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cost of keeping the whitelist up to date is greater than the benefit
from having the check so simply remove it.
Signed-off-by: Ashley Pittman ashley.m.pittman@intel.com