Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-7119 control: exit nonzero from dmg storage cmd --json (#5221) #5330

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

tanabarr
Copy link
Contributor

@tanabarr tanabarr commented Apr 5, 2021

When a dmg storage command e.g. format is run with --json option set
exit with nonzero rc if host errors are contained in response. Output
error related text to stderr not stdout and update nlt to reflect that.

Signed-off-by: Tom Nabarro tom.nabarro@intel.com

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

When a dmg storage command e.g. format is run with --json option set,
exit with nonzero rc if host errors are contained in response. Output
error related text to stderr not stdout and update nlt to reflect that.

Signed-off-by: Tom Nabarro tom.nabarro@intel.com
@tanabarr tanabarr force-pushed the tanabarr/control-dmg-storage-rc-rel1_2 branch from f9448b8 to faccc2d Compare April 7, 2021 10:41
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@tanabarr tanabarr requested a review from a team April 7, 2021 20:36
@mjmac mjmac merged commit 5ee4738 into release/1.2 Apr 9, 2021
@mjmac mjmac deleted the tanabarr/control-dmg-storage-rc-rel1_2 branch April 9, 2021 14:59
@ashleypittman ashleypittman mentioned this pull request Apr 28, 2021
@ashleypittman ashleypittman mentioned this pull request May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants