DAOS-7043 engine: switch module unload and iv fini #5065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daosbuild1
reviewed
Mar 18, 2021
jolivier23
previously approved these changes
Mar 18, 2021
liuxuezhao
previously approved these changes
Mar 21, 2021
daosbuild1
reviewed
Mar 26, 2021
Do IV fini before module unload, because iv_fini will need some iv class operation, which might be destoryed during module unload. Remove some error message in CRT IV, which might be possible during shutdown process, to satisfy the NLT checking. Signed-off-by: Di Wang <di.wang@intel.com>
daosbuild1
reviewed
Mar 26, 2021
liuxuezhao
approved these changes
Mar 29, 2021
daosbuild1
reviewed
Mar 29, 2021
jolivier23
approved these changes
Mar 29, 2021
|
Did something happen to the tests on the patch here? Or has it literally been waiting 4 days in queue? |
daosbuild1
reviewed
Apr 5, 2021
daosbuild1
reviewed
Apr 7, 2021
wangdi1
pushed a commit
that referenced
this pull request
Apr 9, 2021
Do IV fini before module unload, because iv_fini will need some iv class operation, which might be destoryed during module unload. Remove some error message in CRT IV, which might be possible during shutdown process, to satisfy the NLT checking. Signed-off-by: Di Wang <di.wang@intel.com>
johannlombardi
pushed a commit
that referenced
this pull request
Apr 12, 2021
Do IV fini before module unload, because iv_fini will need some iv class operation, which might be destoryed during module unload. Remove some error message in CRT IV, which might be possible during shutdown process, to satisfy the NLT checking. Signed-off-by: Di Wang <di.wang@intel.com>
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do IV fini before module unload, because iv_fini will
need some iv class operation, which might be destoryed
during module unload.
Signed-off-by: Di Wang di.wang@intel.com