DAOS-7165 VOS: free VOS pools attached on GC (#5472) #5561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A pool is attached on GC when user deleted things from the pool, it will be removed from GC only if the pool is destroyed or has nothing to be freed. If DAOS is shutting down before GC frees everything for a alive pool, it will trigger a false assertion because this pool is still attached on GC. - This patch removes the false assertion, it can free all pools still attached on GC while finilizing VOS. - It also includes a small cleanup for VOS API. Signed-off-by: Liang Zhen <liang.zhen@intel.com> Co-authored-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
daosbuild1
reviewed
Apr 25, 2021
NiuYawei
approved these changes
Apr 25, 2021
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pool is attached on GC when user deleted things from the pool,
it will be removed from GC only if the pool is destroyed or has
nothing to be freed. If DAOS is shutting down before GC frees
everything for a alive pool, it will trigger a false assertion
because this pool is still attached on GC.
still attached on GC while finilizing VOS.
Signed-off-by: Liang Zhen liang.zhen@intel.com
Co-authored-by: Mohamad Chaarawi mohamad.chaarawi@intel.com