Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-6865 tests: Providing debug info (#4902) #5288

Merged
merged 2 commits into from
Apr 3, 2021
Merged

Conversation

saurabhtandan
Copy link
Contributor

Using dts_oid_gen to generate a unique object ID for each
TestContainerData object.
Modified rebuild_test_base.py and and test yaml file
Modified test files after vm cores were increased on CI side.
Updated skip ticket for multipool scenario
Re-enabling pool rebuild_test with 20 objects

Test-tag-vm: pr,-hw rebuild_tests

Signed-off-by: Saurabh Tandan saurabh.tandan@intel.com

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

FYI: Errors found in lines not modified in the patch:

src/client/pydaos/raw/daos_api.py:1:
(pylint-too-many-lines) Too many lines in module (2289/1000)

src/client/pydaos/raw/daos_api.py:1408:
(lint) This should ideally fail.

src/client/pydaos/raw/daos_api.py:19:
(pylint-relative-beyond-top-level) Attempted relative import beyond top-level package

src/client/pydaos/raw/daos_api.py:20:
(pylint-relative-beyond-top-level) Attempted relative import beyond top-level package

src/client/pydaos/raw/daos_api.py:21:
(pylint-relative-beyond-top-level) Attempted relative import beyond top-level package

src/client/pydaos/raw/daos_api.py:25:
(pylint-relative-beyond-top-level) Attempted relative import beyond top-level package

src/client/pydaos/raw/daos_api.py:27:
(pylint-relative-beyond-top-level) Attempted relative import beyond top-level package

src/client/pydaos/raw/daos_api.py:85:
(pylint-no-else-raise) Unnecessary "else" after "raise"

src/client/pydaos/raw/daos_api.py:108:
(pylint-no-else-raise) Unnecessary "else" after "raise"

src/client/pydaos/raw/daos_api.py:144:
(pylint-unused-argument) Unused argument 'context'

src/client/pydaos/raw/daos_api.py:292:
(pylint-no-else-return) Unnecessary "else" after "return"

src/client/pydaos/raw/daos_api.py:326:
(pylint-no-else-raise) Unnecessary "else" after "raise"

src/client/pydaos/raw/daos_api.py:586:
(pylint-raise-missing-from) Consider explicitly re-raising using the 'from' keyword

src/client/pydaos/raw/daos_api.py:920:
(pylint-unnecessary-pass) Unnecessary pass statement

src/client/pydaos/raw/daos_api.py:1448:
(pylint-no-else-raise) Unnecessary "else" after "raise"

src/client/pydaos/raw/daos_api.py:1356:
(pylint-too-many-branches) Too many branches (27/25)

src/client/pydaos/raw/daos_api.py:1485:
(pylint-no-else-raise) Unnecessary "else" after "raise"

src/client/pydaos/raw/daos_api.py:1522:
(pylint-no-else-raise) Unnecessary "else" after "raise"

src/client/pydaos/raw/daos_api.py:1552:
(pylint-no-else-raise) Unnecessary "else" after "raise"

src/client/pydaos/raw/daos_api.py:1576:
(pylint-no-else-return) Unnecessary "else" after "return"

src/client/pydaos/raw/daos_api.py:1857:
(pylint-unused-argument) Unused argument 'context'

src/client/pydaos/raw/daos_api.py:2271:
(pylint-protected-access) Access to a protected member _getframe of a client class

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

FYI: Errors found in lines not modified in the patch:

src/client/pydaos/raw/daos_api.py:1:
(pylint-too-many-lines) Too many lines in module (2289/1000)

src/client/pydaos/raw/daos_api.py:1408:
(lint) This should ideally fail.

src/client/pydaos/raw/daos_api.py:19:
(pylint-relative-beyond-top-level) Attempted relative import beyond top-level package

src/client/pydaos/raw/daos_api.py:20:
(pylint-relative-beyond-top-level) Attempted relative import beyond top-level package

src/client/pydaos/raw/daos_api.py:21:
(pylint-relative-beyond-top-level) Attempted relative import beyond top-level package

src/client/pydaos/raw/daos_api.py:25:
(pylint-relative-beyond-top-level) Attempted relative import beyond top-level package

src/client/pydaos/raw/daos_api.py:27:
(pylint-relative-beyond-top-level) Attempted relative import beyond top-level package

src/client/pydaos/raw/daos_api.py:85:
(pylint-no-else-raise) Unnecessary "else" after "raise"

src/client/pydaos/raw/daos_api.py:108:
(pylint-no-else-raise) Unnecessary "else" after "raise"

src/client/pydaos/raw/daos_api.py:144:
(pylint-unused-argument) Unused argument 'context'

src/client/pydaos/raw/daos_api.py:292:
(pylint-no-else-return) Unnecessary "else" after "return"

src/client/pydaos/raw/daos_api.py:326:
(pylint-no-else-raise) Unnecessary "else" after "raise"

src/client/pydaos/raw/daos_api.py:586:
(pylint-raise-missing-from) Consider explicitly re-raising using the 'from' keyword

src/client/pydaos/raw/daos_api.py:920:
(pylint-unnecessary-pass) Unnecessary pass statement

src/client/pydaos/raw/daos_api.py:1448:
(pylint-no-else-raise) Unnecessary "else" after "raise"

src/client/pydaos/raw/daos_api.py:1356:
(pylint-too-many-branches) Too many branches (27/25)

src/client/pydaos/raw/daos_api.py:1485:
(pylint-no-else-raise) Unnecessary "else" after "raise"

src/client/pydaos/raw/daos_api.py:1522:
(pylint-no-else-raise) Unnecessary "else" after "raise"

src/client/pydaos/raw/daos_api.py:1552:
(pylint-no-else-raise) Unnecessary "else" after "raise"

src/client/pydaos/raw/daos_api.py:1576:
(pylint-no-else-return) Unnecessary "else" after "return"

src/client/pydaos/raw/daos_api.py:1857:
(pylint-unused-argument) Unused argument 'context'

src/client/pydaos/raw/daos_api.py:2271:
(pylint-protected-access) Access to a protected member _getframe of a client class

@daosbuild1
Copy link
Collaborator

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

FYI: Errors found in lines not modified in the patch:

src/client/pydaos/raw/daos_api.py:1:
(pylint-too-many-lines) Too many lines in module (2289/1000)

src/client/pydaos/raw/daos_api.py:1408:
(lint) This should ideally fail.

src/client/pydaos/raw/daos_api.py:19:
(pylint-relative-beyond-top-level) Attempted relative import beyond top-level package

src/client/pydaos/raw/daos_api.py:20:
(pylint-relative-beyond-top-level) Attempted relative import beyond top-level package

src/client/pydaos/raw/daos_api.py:21:
(pylint-relative-beyond-top-level) Attempted relative import beyond top-level package

src/client/pydaos/raw/daos_api.py:25:
(pylint-relative-beyond-top-level) Attempted relative import beyond top-level package

src/client/pydaos/raw/daos_api.py:27:
(pylint-relative-beyond-top-level) Attempted relative import beyond top-level package

src/client/pydaos/raw/daos_api.py:85:
(pylint-no-else-raise) Unnecessary "else" after "raise"

src/client/pydaos/raw/daos_api.py:108:
(pylint-no-else-raise) Unnecessary "else" after "raise"

src/client/pydaos/raw/daos_api.py:144:
(pylint-unused-argument) Unused argument 'context'

src/client/pydaos/raw/daos_api.py:292:
(pylint-no-else-return) Unnecessary "else" after "return"

src/client/pydaos/raw/daos_api.py:326:
(pylint-no-else-raise) Unnecessary "else" after "raise"

src/client/pydaos/raw/daos_api.py:586:
(pylint-raise-missing-from) Consider explicitly re-raising using the 'from' keyword

src/client/pydaos/raw/daos_api.py:920:
(pylint-unnecessary-pass) Unnecessary pass statement

src/client/pydaos/raw/daos_api.py:1448:
(pylint-no-else-raise) Unnecessary "else" after "raise"

src/client/pydaos/raw/daos_api.py:1356:
(pylint-too-many-branches) Too many branches (27/25)

src/client/pydaos/raw/daos_api.py:1485:
(pylint-no-else-raise) Unnecessary "else" after "raise"

src/client/pydaos/raw/daos_api.py:1522:
(pylint-no-else-raise) Unnecessary "else" after "raise"

src/client/pydaos/raw/daos_api.py:1552:
(pylint-no-else-raise) Unnecessary "else" after "raise"

src/client/pydaos/raw/daos_api.py:1576:
(pylint-no-else-return) Unnecessary "else" after "return"

src/client/pydaos/raw/daos_api.py:1857:
(pylint-unused-argument) Unused argument 'context'

src/client/pydaos/raw/daos_api.py:2271:
(pylint-protected-access) Access to a protected member _getframe of a client class

Using dts_oid_gen to generate a unique object ID for each
TestContainerData object.
Modified rebuild_test_base.py and and test yaml file
Modified test files after vm cores were increased on CI side.
Updated skip ticket for multipool scenario
Re-enabling pool rebuild_test with 20 objects

Test-tag-vm: pr,-hw rebuild_tests
Allow-unstable-test: true

Signed-off-by: Saurabh Tandan <saurabh.tandan@intel.com>
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

FYI: Errors found in lines not modified in the patch:

src/client/pydaos/raw/daos_api.py:1:
(pylint-too-many-lines) Too many lines in module (2289/1000)

src/client/pydaos/raw/daos_api.py:1408:
(lint) This should ideally fail.

src/client/pydaos/raw/daos_api.py:19:
(pylint-relative-beyond-top-level) Attempted relative import beyond top-level package

src/client/pydaos/raw/daos_api.py:20:
(pylint-relative-beyond-top-level) Attempted relative import beyond top-level package

src/client/pydaos/raw/daos_api.py:21:
(pylint-relative-beyond-top-level) Attempted relative import beyond top-level package

src/client/pydaos/raw/daos_api.py:25:
(pylint-relative-beyond-top-level) Attempted relative import beyond top-level package

src/client/pydaos/raw/daos_api.py:27:
(pylint-relative-beyond-top-level) Attempted relative import beyond top-level package

src/client/pydaos/raw/daos_api.py:85:
(pylint-no-else-raise) Unnecessary "else" after "raise"

src/client/pydaos/raw/daos_api.py:108:
(pylint-no-else-raise) Unnecessary "else" after "raise"

src/client/pydaos/raw/daos_api.py:144:
(pylint-unused-argument) Unused argument 'context'

src/client/pydaos/raw/daos_api.py:292:
(pylint-no-else-return) Unnecessary "else" after "return"

src/client/pydaos/raw/daos_api.py:326:
(pylint-no-else-raise) Unnecessary "else" after "raise"

src/client/pydaos/raw/daos_api.py:586:
(pylint-raise-missing-from) Consider explicitly re-raising using the 'from' keyword

src/client/pydaos/raw/daos_api.py:920:
(pylint-unnecessary-pass) Unnecessary pass statement

src/client/pydaos/raw/daos_api.py:1448:
(pylint-no-else-raise) Unnecessary "else" after "raise"

src/client/pydaos/raw/daos_api.py:1356:
(pylint-too-many-branches) Too many branches (27/25)

src/client/pydaos/raw/daos_api.py:1485:
(pylint-no-else-raise) Unnecessary "else" after "raise"

src/client/pydaos/raw/daos_api.py:1522:
(pylint-no-else-raise) Unnecessary "else" after "raise"

src/client/pydaos/raw/daos_api.py:1552:
(pylint-no-else-raise) Unnecessary "else" after "raise"

src/client/pydaos/raw/daos_api.py:1576:
(pylint-no-else-return) Unnecessary "else" after "return"

src/client/pydaos/raw/daos_api.py:1857:
(pylint-unused-argument) Unused argument 'context'

src/client/pydaos/raw/daos_api.py:2271:
(pylint-protected-access) Access to a protected member _getframe of a client class

@daosbuild1
Copy link
Collaborator

Test stage Functional on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5288/6/execution/node/1191/log

Test-tag-vm: pr,-hw rebuild_tests
Allow-unstable-test: true
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@jolivier23 jolivier23 merged commit e69ed53 into release/1.2 Apr 3, 2021
@jolivier23 jolivier23 deleted the DAOS-6865_1.2 branch April 3, 2021 02:56
@ashleypittman ashleypittman mentioned this pull request Apr 28, 2021
@ashleypittman ashleypittman mentioned this pull request May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants