DAOS-6572 engine: Use CDEBUG to silence shutdown warnings. #4859

ashleypittman · 2021-03-04T09:01:18Z

No description provided.

src/container/srv_target.c

daosbuild1 · 2021-03-04T09:03:42Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4859/1/execution/node/72/log

daosbuild1 · 2021-03-04T09:10:46Z

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4859/1/execution/node/390/log

daosbuild1 · 2021-03-04T09:12:11Z

Test stage Build RPM on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4859/1/execution/node/393/log

Silence errors at shutdown. Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>

Updated patch

daosbuild1

LGTM. No errors found by checkpatch.

Parallel-build: true Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>

daosbuild1

LGTM. No errors found by checkpatch.

FYI: Errors found in lines not modified in the patch:

src/tests/ftest/cart/util/cart_logtest.py:373:
(pylint-redefined-outer-name) Redefining name 'pid' from outer scope (line 356)

src/tests/ftest/cart/util/cart_logtest.py:438:
(pylint-chained-comparison) Simplify chained comparison between the operands

daosbuild1 · 2021-03-04T16:42:43Z

Test stage NLT completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4859/3/execution/node/879/log

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-4859/4/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

FYI: Errors found in lines not modified in the patch:

src/tests/ftest/cart/util/cart_logparse.py:52:
(pylint-unnecessary-pass) Unnecessary pass statement

src/tests/ftest/cart/util/cart_logparse.py:56:
(pylint-unnecessary-pass) Unnecessary pass statement

src/tests/ftest/cart/util/cart_logparse.py:131:
(pylint-raise-missing-from) Consider explicitly re-raising using the 'from' keyword

src/tests/ftest/cart/util/cart_logparse.py:580:
(pylint-raise-missing-from) Consider explicitly re-raising using the 'from' keyword

src/tests/ftest/cart/util/cart_logparse.py:633:
(pylint-raise-missing-from) Consider explicitly re-raising using the 'from' keyword

src/tests/ftest/cart/util/cart_logtest.py:373:
(pylint-redefined-outer-name) Redefining name 'pid' from outer scope (line 356)

src/tests/ftest/cart/util/cart_logtest.py:439:
(pylint-chained-comparison) Simplify chained comparison between the operands

daosbuild1 · 2021-03-04T19:32:50Z

src/tests/ftest/cart/util/cart_logtest.py

@@ -417,6 +418,9 @@ def _check_pid_from_log_file(self,
            except AttributeError:
                pass
            if abort_on_warning:
+                if not server_shutdown and \
+                   line.fac != 'external' and line.function == 'server_fini':
+                        server_shutdown = True


(pylint-bad-indentation) Bad indentation. Found 24 spaces, expected 20

daosbuild1 · 2021-03-04T19:32:53Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4859/4/execution/node/72/log

Parallel-build: true Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>

Updated patch

daosbuild1

LGTM. No errors found by checkpatch.

FYI: Errors found in lines not modified in the patch:

src/tests/ftest/cart/util/cart_logparse.py:52:
(pylint-unnecessary-pass) Unnecessary pass statement

src/tests/ftest/cart/util/cart_logparse.py:56:
(pylint-unnecessary-pass) Unnecessary pass statement

src/tests/ftest/cart/util/cart_logparse.py:131:
(pylint-raise-missing-from) Consider explicitly re-raising using the 'from' keyword

src/tests/ftest/cart/util/cart_logparse.py:580:
(pylint-raise-missing-from) Consider explicitly re-raising using the 'from' keyword

src/tests/ftest/cart/util/cart_logparse.py:633:
(pylint-raise-missing-from) Consider explicitly re-raising using the 'from' keyword

src/tests/ftest/cart/util/cart_logtest.py:373:
(pylint-redefined-outer-name) Redefining name 'pid' from outer scope (line 356)

src/tests/ftest/cart/util/cart_logtest.py:439:
(pylint-chained-comparison) Simplify chained comparison between the operands

daosbuild1

LGTM. No errors found by checkpatch.

FYI: Errors found in lines not modified in the patch:

src/tests/ftest/cart/util/cart_logparse.py:52:
(pylint-unnecessary-pass) Unnecessary pass statement

src/tests/ftest/cart/util/cart_logparse.py:56:
(pylint-unnecessary-pass) Unnecessary pass statement

src/tests/ftest/cart/util/cart_logparse.py:131:
(pylint-raise-missing-from) Consider explicitly re-raising using the 'from' keyword

src/tests/ftest/cart/util/cart_logparse.py:580:
(pylint-raise-missing-from) Consider explicitly re-raising using the 'from' keyword

src/tests/ftest/cart/util/cart_logparse.py:633:
(pylint-raise-missing-from) Consider explicitly re-raising using the 'from' keyword

daosbuild1 · 2021-03-05T05:01:55Z

Test stage Scan CentOS 7 RPMs completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4859/6/execution/node/1207/log

daosbuild1 · 2021-03-05T05:03:28Z

Test stage Functional_Hardware_Small completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4859/6/execution/node/1233/log

daosbuild1 · 2021-03-05T08:48:44Z

Test stage Functional_Hardware_Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4859/6/execution/node/1325/log

daosbuild1 · 2021-03-05T12:07:37Z

Test stage Functional_Hardware_Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4859/6/execution/node/1397/log

daosbuild1

LGTM. No errors found by checkpatch.

FYI: Errors found in lines not modified in the patch:

src/tests/ftest/cart/util/cart_logparse.py:52:
(pylint-unnecessary-pass) Unnecessary pass statement

src/tests/ftest/cart/util/cart_logparse.py:56:
(pylint-unnecessary-pass) Unnecessary pass statement

src/tests/ftest/cart/util/cart_logparse.py:131:
(pylint-raise-missing-from) Consider explicitly re-raising using the 'from' keyword

src/tests/ftest/cart/util/cart_logparse.py:580:
(pylint-raise-missing-from) Consider explicitly re-raising using the 'from' keyword

src/tests/ftest/cart/util/cart_logparse.py:633:
(pylint-raise-missing-from) Consider explicitly re-raising using the 'from' keyword

daosbuild1 · 2021-03-05T15:04:40Z

Test stage Scan CentOS 7 RPMs completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4859/7/execution/node/1142/log

Parallel-build: true

daosbuild1

LGTM. No errors found by checkpatch.

FYI: Errors found in lines not modified in the patch:

src/tests/ftest/cart/util/cart_logparse.py:52:
(pylint-unnecessary-pass) Unnecessary pass statement

src/tests/ftest/cart/util/cart_logparse.py:56:
(pylint-unnecessary-pass) Unnecessary pass statement

src/tests/ftest/cart/util/cart_logparse.py:131:
(pylint-raise-missing-from) Consider explicitly re-raising using the 'from' keyword

src/tests/ftest/cart/util/cart_logparse.py:580:
(pylint-raise-missing-from) Consider explicitly re-raising using the 'from' keyword

src/tests/ftest/cart/util/cart_logparse.py:633:
(pylint-raise-missing-from) Consider explicitly re-raising using the 'from' keyword

daosbuild1

LGTM. No errors found by checkpatch.

FYI: Errors found in lines not modified in the patch:

src/tests/ftest/cart/util/cart_logparse.py:52:
(pylint-unnecessary-pass) Unnecessary pass statement

src/tests/ftest/cart/util/cart_logparse.py:56:
(pylint-unnecessary-pass) Unnecessary pass statement

src/tests/ftest/cart/util/cart_logparse.py:131:
(pylint-raise-missing-from) Consider explicitly re-raising using the 'from' keyword

src/tests/ftest/cart/util/cart_logparse.py:580:
(pylint-raise-missing-from) Consider explicitly re-raising using the 'from' keyword

src/tests/ftest/cart/util/cart_logparse.py:633:
(pylint-raise-missing-from) Consider explicitly re-raising using the 'from' keyword

Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>

daosbuild1

LGTM. No errors found by checkpatch.

FYI: Errors found in lines not modified in the patch:

src/tests/ftest/cart/util/cart_logparse.py:52:
(pylint-unnecessary-pass) Unnecessary pass statement

src/tests/ftest/cart/util/cart_logparse.py:56:
(pylint-unnecessary-pass) Unnecessary pass statement

src/tests/ftest/cart/util/cart_logparse.py:131:
(pylint-raise-missing-from) Consider explicitly re-raising using the 'from' keyword

src/tests/ftest/cart/util/cart_logparse.py:580:
(pylint-raise-missing-from) Consider explicitly re-raising using the 'from' keyword

src/tests/ftest/cart/util/cart_logparse.py:633:
(pylint-raise-missing-from) Consider explicitly re-raising using the 'from' keyword

Silence errors at shutdown. Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>

…5199) Silence errors at shutdown. Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>

daosbuild1 previously requested changes Mar 4, 2021

View reviewed changes

src/container/srv_target.c Outdated Show resolved Hide resolved

DAOS-6572 engine: Use CDEBUG to silence shutdown warnings.

757905c

Silence errors at shutdown. Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>

ashleypittman force-pushed the cdebug-warnings branch from 4188e7a to 757905c Compare March 4, 2021 09:13

daosbuild1 reviewed Mar 4, 2021

View reviewed changes

Silence all DER_SHUTDOWN warnings during shutdown.

8c3646d

Parallel-build: true Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>

daosbuild1 reviewed Mar 4, 2021

View reviewed changes

daosbuild1 previously requested changes Mar 4, 2021

View reviewed changes

Fix crash and improve line matching.

2be3918

Parallel-build: true Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>

ashleypittman force-pushed the cdebug-warnings branch from 64a75c6 to 2be3918 Compare March 4, 2021 19:36

daosbuild1 reviewed Mar 4, 2021

View reviewed changes

Merge branch 'master' into cdebug-warnings

11638af

daosbuild1 reviewed Mar 4, 2021

View reviewed changes

Merge branch 'master' into cdebug-warnings

e1147f0

daosbuild1 reviewed Mar 5, 2021

View reviewed changes

Merge branch 'master' into cdebug-warnings

db26b1f

Parallel-build: true

daosbuild1 reviewed Mar 5, 2021

View reviewed changes

Merge branch 'master' into cdebug-warnings

7abf8ec

daosbuild1 reviewed Mar 8, 2021

View reviewed changes

Back out debugging.

3ee0f5d

Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>

daosbuild1 reviewed Mar 8, 2021

View reviewed changes

ashleypittman requested review from jgmoore-or, jolivier23 and NiuYawei March 8, 2021 19:57

jolivier23 approved these changes Mar 8, 2021

View reviewed changes

jgmoore-or approved these changes Mar 8, 2021

View reviewed changes

NiuYawei approved these changes Mar 9, 2021

View reviewed changes

ashleypittman requested a review from a team March 9, 2021 07:54

jolivier23 merged commit bf542a7 into master Mar 9, 2021

jolivier23 deleted the cdebug-warnings branch March 9, 2021 23:57

sylviachanoiyee pushed a commit that referenced this pull request Mar 26, 2021

DAOS-6572 engine: Use CDEBUG to silence shutdown warnings. (#4859)

98e1626

Silence errors at shutdown. Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>

sylviachanoiyee pushed a commit that referenced this pull request Mar 26, 2021

DAOS-6572 engine: Use CDEBUG to silence shutdown warnings. (#4859)

5a10c28

Silence errors at shutdown. Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>

sylviachanoiyee pushed a commit that referenced this pull request Apr 2, 2021

DAOS-6572 engine: Use CDEBUG to silence shutdown warnings. (#4859) (#…

c13047f

…5199) Silence errors at shutdown. Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>

ashleypittman mentioned this pull request Apr 28, 2021

1.2 dfuse single #5582

Closed

ashleypittman mentioned this pull request May 20, 2021

1.2 proc #5753

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DAOS-6572 engine: Use CDEBUG to silence shutdown warnings. #4859

DAOS-6572 engine: Use CDEBUG to silence shutdown warnings. #4859

ashleypittman commented Mar 4, 2021

daosbuild1 commented Mar 4, 2021

daosbuild1 commented Mar 4, 2021

daosbuild1 commented Mar 4, 2021

daosbuild1 left a comment

daosbuild1 left a comment

daosbuild1 commented Mar 4, 2021

daosbuild1 left a comment

daosbuild1 Mar 4, 2021

daosbuild1 commented Mar 4, 2021

daosbuild1 left a comment

daosbuild1 left a comment

daosbuild1 commented Mar 5, 2021

daosbuild1 commented Mar 5, 2021

daosbuild1 commented Mar 5, 2021

daosbuild1 commented Mar 5, 2021

daosbuild1 left a comment

daosbuild1 commented Mar 5, 2021

daosbuild1 left a comment

daosbuild1 left a comment

daosbuild1 left a comment

DAOS-6572 engine: Use CDEBUG to silence shutdown warnings. #4859

DAOS-6572 engine: Use CDEBUG to silence shutdown warnings. #4859

Conversation

ashleypittman commented Mar 4, 2021

daosbuild1 commented Mar 4, 2021

daosbuild1 commented Mar 4, 2021

daosbuild1 commented Mar 4, 2021

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 commented Mar 4, 2021

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 Mar 4, 2021

Choose a reason for hiding this comment

daosbuild1 commented Mar 4, 2021

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 commented Mar 5, 2021

daosbuild1 commented Mar 5, 2021

daosbuild1 commented Mar 5, 2021

daosbuild1 commented Mar 5, 2021

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 commented Mar 5, 2021

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 left a comment

Choose a reason for hiding this comment