jgm/daos-4698-1: Rebuild object migration should execute applicable object punch for each migration. #4895

jgmoore-or · 2021-03-05T22:20:46Z

Added object punch epoch to object enumeration. Execute the punch during migrate.

Add future object punch epoch to key iterator. Needed for rebuild migration so we can rebuild punched objects that are visible in a prior snapshot. Signed-off-by: Jeff Olivier <jeffrey.v.olivier@intel.com>

Signed-off-by: Joseph Moore <joseph.moore@intel.com>

daosbuild1

LGTM. No errors found by checkpatch.

…d targets. Signed-off-by: Joseph Moore <joseph.moore@intel.com>

daosbuild1

LGTM. No errors found by checkpatch.

… object punch for each migration. Signed-off-by: Joseph Moore <joseph.moore@intel.com>

daosbuild1

LGTM. No errors found by checkpatch.

…object punch for each migration. Signed-off-by: Joseph Moore <joseph.moore@intel.com>

… object punch for each migration. Signed-off-by: Joseph Moore <joseph.moore@intel.com>

daosbuild1

LGTM. No errors found by checkpatch.

wangdi1 · 2021-03-08T05:59:57Z

src/object/obj_enum.c

+		iov->iov_len += pi_size;
+		arg->obj_punched = true;
+	}
+


I thought we will get object punch epoch by scan. see rebuild_obj_scan_cb() L601. So you do not need change enumerate packing.
Anything concern?

I discussed this option with Jeff. He says the scan only picks up the latest punch. For the incarnation log problem we're trying to solve, the subsequent punch closest to the update epoch must be replayed. There can be multiple object punches at differing epochs for an object, and recording them in the enumeration packing is required.

The latest isn't sufficient. You could have many snapshots you are rebuilding. As such, you could have something like this

update object at time 1
take snapshot at 2
punch at 3
update a at 4
snapshot at 5
punch at 6

If you rebuild the object at 7, you will only see the punch at 6 in the scan phase. You only see the intermediate punch 3 while you are doing migration for the snapshot at 2. So you can't do this at the scan phase.

ah, right. Thanks for explanation.

wangdi1

Probably add a few more snapshots and punch in rebuild_snap_punch_empty() test. Thanks.

wangdi1 · 2021-03-08T23:33:47Z

src/object/srv_obj_migrate.c

+		rc = vos_obj_punch(cont->sc_hdl, mrone->mo_oid,
+				   mrone->mo_obj_punch_eph,
+				   tls->mpt_version, VOS_OF_REPLAY_PC,
+				   NULL, 0, NULL, NULL);


@jolivier23 is it ok for VOS to punch the same object with same epoch multiple times?

It should be ok with the VOS_OF_REPLAY_PC flag. If it doesn't work, it's a bug

wangdi1 · 2021-03-08T23:35:58Z

src/object/srv_obj_migrate.c

+		if (rc) {
+			D_ERROR(DF_UOID" punch obj failed: rc %d\n",
+				DP_UOID(mrone->mo_oid), rc);
+			return rc;


D_GOTO(obj_close, rc) ?

This has been fixed.

…t objects. Signed-off-by: Joseph Moore <joseph.moore@intel.com>

daosbuild1

LGTM. No errors found by checkpatch.

jolivier23

Need to revert the submodule update

Signed-off-by: Joseph Moore <joseph.moore@intel.com>

daosbuild1

LGTM. No errors found by checkpatch.

wangdi1

Thanks. Joe

johannlombardi · 2021-03-25T12:04:14Z

Should be ported to 1.2 since this is a 1.2 blocker.

… object punch for each migration. (#4895) Added object punch epoch to object enumeration. Execute the punch during migrate. Signed-off-by: Joseph Moore <joseph.moore@intel.com>

… object punch for each migration. (#4895) (#5188) Added object punch epoch to object enumeration. Execute the punch during migrate. Signed-off-by: Joseph Moore <joseph.moore@intel.com>

jolivier23 and others added 4 commits March 3, 2021 14:32

DAOS-4698 vos: Report future object punch with iterator

537c5de

Add future object punch epoch to key iterator. Needed for rebuild migration so we can rebuild punched objects that are visible in a prior snapshot. Signed-off-by: Jeff Olivier <jeffrey.v.olivier@intel.com>

Merge branch 'jvolivie/vos_obj_iter' into jgm/DAOS-4698-1

bdf8ea9

DAOS-4698 rebuild: Propagate object punch to rebuild targets.

003f5bd

Signed-off-by: Joseph Moore <joseph.moore@intel.com>

Merge branch 'master' into jgm/DAOS-4698-1

aea12e3

daosbuild1 reviewed Mar 5, 2021

View reviewed changes

jgmoore-or requested a review from jolivier23 March 5, 2021 22:26

DAOS-4698 rebuild: Modify rebuild to propagate object punch to rebuil…

841737a

…d targets. Signed-off-by: Joseph Moore <joseph.moore@intel.com>

daosbuild1 reviewed Mar 5, 2021

View reviewed changes

DAOS-4698 rebuild: Rebuild object migration should execute applicable…

cf9a88e

… object punch for each migration. Signed-off-by: Joseph Moore <joseph.moore@intel.com>

daosbuild1 reviewed Mar 6, 2021

View reviewed changes

jgmoore-or requested review from wangdi1, johannlombardi and gnailzenh March 6, 2021 20:39

jgmoore-or added 2 commits March 6, 2021 20:59

DAOS4698 rebuild: Rebuild object migration should execute applicable …

dbc8219

…object punch for each migration. Signed-off-by: Joseph Moore <joseph.moore@intel.com>

DAOS-4698 rebuild: Rebuild object migration should execute applicable…

b33b1fd

… object punch for each migration. Signed-off-by: Joseph Moore <joseph.moore@intel.com>

daosbuild1 reviewed Mar 6, 2021

View reviewed changes

wangdi1 reviewed Mar 8, 2021

View reviewed changes

jgmoore-or requested review from daosbuild1 and wangdi1 March 8, 2021 15:26

jolivier23 previously approved these changes Mar 8, 2021

View reviewed changes

wangdi1 reviewed Mar 8, 2021

View reviewed changes

DAOS-4698 rebuild: Modify rebuild to propagate object punch to rebuil…

64a7590

…t objects. Signed-off-by: Joseph Moore <joseph.moore@intel.com>

jgmoore-or dismissed jolivier23’s stale review via 64a7590 March 9, 2021 14:54

daosbuild1 reviewed Mar 9, 2021

View reviewed changes

jgmoore-or requested review from jolivier23 and wangdi1 March 9, 2021 14:57

jolivier23 requested changes Mar 9, 2021

View reviewed changes

DAOS-4698 rebuild: Modify rebuild to replay object punch.

49f9c44

Signed-off-by: Joseph Moore <joseph.moore@intel.com>

daosbuild1 reviewed Mar 9, 2021

View reviewed changes

jgmoore-or requested a review from jolivier23 March 10, 2021 14:01

jolivier23 approved these changes Mar 10, 2021

View reviewed changes

wangdi1 approved these changes Mar 10, 2021

View reviewed changes

jgmoore-or requested a review from a team March 11, 2021 15:51

jolivier23 merged commit cf17bc5 into master Mar 11, 2021

jolivier23 deleted the jgm/DAOS-4698-1 branch March 11, 2021 17:15

ashleypittman mentioned this pull request Apr 28, 2021

1.2 dfuse single #5582

Closed

ashleypittman mentioned this pull request May 20, 2021

1.2 proc #5753

Closed

jgm/daos-4698-1: Rebuild object migration should execute applicable object punch for each migration. #4895

jgm/daos-4698-1: Rebuild object migration should execute applicable object punch for each migration. #4895

Uh oh!

Conversation

jgmoore-or commented Mar 5, 2021

Uh oh!

daosbuild1 left a comment

Choose a reason for hiding this comment

Uh oh!

daosbuild1 left a comment

Choose a reason for hiding this comment

Uh oh!

daosbuild1 left a comment

Choose a reason for hiding this comment

Uh oh!

daosbuild1 left a comment

Choose a reason for hiding this comment

Uh oh!

wangdi1 Mar 8, 2021

Choose a reason for hiding this comment

Uh oh!

jgmoore-or Mar 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jolivier23 Mar 8, 2021

Choose a reason for hiding this comment

Uh oh!

wangdi1 Mar 8, 2021

Choose a reason for hiding this comment

Uh oh!

wangdi1 left a comment

Choose a reason for hiding this comment

Uh oh!

wangdi1 Mar 8, 2021

Choose a reason for hiding this comment

Uh oh!

jolivier23 Mar 9, 2021

Choose a reason for hiding this comment

Uh oh!

wangdi1 Mar 8, 2021

Choose a reason for hiding this comment

Uh oh!

jgmoore-or Mar 9, 2021

Choose a reason for hiding this comment

Uh oh!

daosbuild1 left a comment

Choose a reason for hiding this comment

Uh oh!

jolivier23 left a comment

Choose a reason for hiding this comment

Uh oh!

daosbuild1 left a comment

Choose a reason for hiding this comment

Uh oh!

wangdi1 left a comment

Choose a reason for hiding this comment

Uh oh!

johannlombardi commented Mar 25, 2021

Uh oh!

Uh oh!

jgmoore-or Mar 8, 2021 •

edited

Loading