DAOS-6916 test: Fix interception library tests by letting threads to have independent data #4828
Conversation
Added control_method: dmg to yaml. Also refactored tags. Quick-build: true Skip-unit-tests: true Test-tag: ior_intercept_verify_data Signed-off-by: Makito Kano <makito.kano@intel.com>
Quick-build: true Skip-unit-tests: true Test-tag: ior_intercept_verify_data Signed-off-by: Makito Kano <makito.kano@intel.com>
There was a problem hiding this comment.
LGTM. No errors found by checkpatch.
FYI: Errors found in lines not modified in the patch:
src/tests/ftest/util/ior_test_base.py:36:
(pylint-super-with-arguments) Consider using Python 3 style super() without arguments
src/tests/ftest/util/ior_test_base.py:48:
(pylint-super-with-arguments) Consider using Python 3 style super() without arguments
src/tests/ftest/util/ior_test_base.py:104:
(pylint-too-many-arguments) Too many arguments (11/10)
|
Test stage Scan CentOS 7 RPMs completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4828/2/execution/node/706/log |
Quick-build: true Skip-unit-tests: true Test-tag: ior_intercept_verify_data iorinterceptmix Signed-off-by: Makito Kano <makito.kano@intel.com>
There was a problem hiding this comment.
LGTM. No errors found by checkpatch.
FYI: Errors found in lines not modified in the patch:
src/tests/ftest/util/ior_test_base.py:36:
(pylint-super-with-arguments) Consider using Python 3 style super() without arguments
src/tests/ftest/util/ior_test_base.py:48:
(pylint-super-with-arguments) Consider using Python 3 style super() without arguments
src/tests/ftest/util/ior_test_base.py:97:
(pylint-too-many-arguments) Too many arguments (11/10)
|
Test stage Scan CentOS 7 RPMs completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4828/3/execution/node/682/log |
Quick-build: true Skip-unit-tests: true Test-tag: ior_intercept_verify_data iorinterceptmix Signed-off-by: Makito Kano <makito.kano@intel.com>
There was a problem hiding this comment.
LGTM. No errors found by checkpatch.
FYI: Errors found in lines not modified in the patch:
src/tests/ftest/util/ior_test_base.py:36:
(pylint-super-with-arguments) Consider using Python 3 style super() without arguments
src/tests/ftest/util/ior_test_base.py:48:
(pylint-super-with-arguments) Consider using Python 3 style super() without arguments
src/tests/ftest/util/ior_test_base.py:97:
(pylint-too-many-arguments) Too many arguments (11/10)
src/tests/ftest/util/ior_test_base.py:9:
(pylint-unused-import) Unused import time
IOR thread was using self.ior_cmd. This will lead to a collision between threads because many things, such as ior command arguments, are shared. Updated ior_test_base.py so that each thread will have its own IorCommand object so that they are independent and no need to sleep between the thread starts. Updated ior_intercept_dfuse_mix.py test steps to do a comaprison of 2 IOR threads throughput performance. Also print out a summary of improvements. Removed use_json from pool_query. Quick-build: true Skip-unit-tests: true Test-tag-hw-large: pr,hw,large ior_intercept_verify_data ior_intercept_mix Signed-off-by: Makito Kano <makito.kano@intel.com>
There was a problem hiding this comment.
Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-4828/5/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules
FYI: Errors found in lines not modified in the patch:
src/tests/ftest/ior/ior_intercept_dfuse_mix.py:23:
(pylint-too-many-locals) Too many local variables (34/30)
src/tests/ftest/util/ior_test_base.py:9:
(pylint-unused-import) Unused import time
|
Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4828/5/execution/node/72/log |
Quick-build: true Skip-unit-tests: true Test-tag-hw-large: pr,hw,large ior_intercept_verify_data ior_intercept_mix Signed-off-by: Makito Kano <makito.kano@intel.com>
There was a problem hiding this comment.
Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-4828/6/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules
|
Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4828/6/execution/node/72/log |
Quick-build: true Skip-unit-tests: true Test-tag-hw-large: pr,hw,large ior_intercept_verify_data ior_intercept_mix Signed-off-by: Makito Kano <makito.kano@intel.com>
There was a problem hiding this comment.
Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-4828/7/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules
FYI: Errors found in lines not modified in the patch:
src/tests/ftest/ior/ior_intercept_dfuse_mix.py:23:
(pylint-too-many-locals) Too many local variables (33/30)
|
Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4828/7/execution/node/73/log |
Quick-build: true Skip-unit-tests: true Test-tag-hw-large: pr,hw,large ior_intercept_verify_data ior_intercept_mix Signed-off-by: Makito Kano <makito.kano@intel.com>
shimizukko
changed the title
…have independent data (#4828) IOR thread was using self.ior_cmd. This will lead to a collision between threads because many things, such as ior command arguments, are shared. Updated ior_test_base.py so that each thread will have its own IorCommand object so that they are independent and no need to sleep between the thread starts. Updated ior_intercept_dfuse_mix.py test steps to do a comparison of 2 IOR threads throughput performance. Also print out a summary of improvements. Removed use_json from pool_query. Added control_method: dmg to yaml. Also refactored tags. Quick-build: true Skip-unit-tests: true Test-tag-hw-large: pr,hw,large ior_intercept_verify_data ior_intercept_mix Signed-off-by: Makito Kano <makito.kano@intel.com>
…have independent data (#4828) (#5243) IOR thread was using self.ior_cmd. This will lead to a collision between threads because many things, such as ior command arguments, are shared. Updated ior_test_base.py so that each thread will have its own IorCommand object so that they are independent and no need to sleep between the thread starts. Updated ior_intercept_dfuse_mix.py test steps to do a comparison of 2 IOR threads throughput performance. Also print out a summary of improvements. Removed use_json from pool_query. Added control_method: dmg to yaml. Also refactored tags. Signed-off-by: Makito Kano <makito.kano@intel.com>
Fixed the interception library tests by letting threads to have independent data so that they don't collide; and we don't need to
wait between starting the threads.
Updated ior_intercept_dfuse_mix.py so that we'll use 2 clients to run IOR with IL and 2 clients without, making the environment
as equal as possible outside of the use of IL. Also simplified the test steps.
Added control_method: dmg to yaml.
Removed use_json from dmg pool query function.
Refactored tags.
Quick-build: true
Skip-unit-tests: true
Test-tag: ior_intercept_verify_data
Signed-off-by: Makito Kano makito.kano@intel.com