Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-6731 sdl: Fix coverity defect in CaRT IV server test #4793

Merged
merged 2 commits into from
Mar 4, 2021
Merged

DAOS-6731 sdl: Fix coverity defect in CaRT IV server test #4793

merged 2 commits into from
Mar 4, 2021

Conversation

sydneyvanda
Copy link
Contributor

Fixes unused value defect in cart iv server functional test.

Signed-off-by: Sydney Vanda sydney.m.vanda@intel.com

@sydneyvanda
DAOS-6731 sdl: Fix coverity defect in CaRT IV server test
2d6734e 
Fixes unused value defect in cart iv server functional test.

Signed-off-by: Sydney Vanda <sydney.m.vanda@intel.com>
daosbuild1
daosbuild1 reviewed Feb 26, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional_Hardware_Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4793/1/execution/node/1531/log

daosbuild1
daosbuild1 reviewed Mar 1, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@sydneyvanda
Copy link
Contributor Author

confirmed the defect (290819) is resolved in recent run with this patch https://scan8.coverity.com/reports.htm#v39476/p12225

@sydneyvanda sydneyvanda requested a review from SABollinger March 1, 2021 21:05
@daosbuild1
Copy link
Collaborator

Test stage Functional_Hardware_Small completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4793/2/execution/node/1387/log

@daosbuild1
Copy link
Collaborator

Test stage Functional_Hardware_Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4793/2/execution/node/1401/log

@daosbuild1
Copy link
Collaborator

Test stage Functional_Hardware_Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4793/2/execution/node/1454/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4793/2/execution/node/1526/log

byron-marohn
byron-marohn approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@byron-marohn byron-marohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of weird, I see assert() and D_ASSERT() used in this same function. Seems like assert() is used more often than D_ASSERT(), so this looks good to me.

Thanks for fixing this.

@sydneyvanda
Copy link
Contributor Author

I noticed that as well, just figured I would stay consistent

@sydneyvanda sydneyvanda requested a review from a team March 2, 2021 22:51
@jolivier23 jolivier23 merged commit 79e895a into master Mar 4, 2021
@jolivier23 jolivier23 deleted the smvanda/daos-6731 branch March 4, 2021 23:25
sydneyvanda added a commit that referenced this pull request Mar 5, 2021
@sydneyvanda
DAOS-6731 sdl: Fix coverity defect in CaRT IV server test (#4793)
e318af2 
Fixes unused value defect in cart iv server functional test.

Signed-off-by: Sydney Vanda <sydney.m.vanda@intel.com>
@sydneyvanda sydneyvanda mentioned this pull request Mar 5, 2021
Merged
jolivier23 pushed a commit that referenced this pull request Mar 9, 2021
@sydneyvanda
DAOS-6731 sdl: Fix coverity defect in CaRT IV server test (#4793) (#4896
f220017 
)

Fixes unused value defect in cart iv server functional test.

Signed-off-by: Sydney Vanda <sydney.m.vanda@intel.com>
@ashleypittman ashleypittman mentioned this pull request Apr 28, 2021
Closed
@ashleypittman ashleypittman mentioned this pull request May 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SABollinger SABollinger SABollinger approved these changes

@frostedcmos frostedcmos frostedcmos approved these changes

@byron-marohn byron-marohn byron-marohn approved these changes

@daosbuild1 daosbuild1 Awaiting requested review from daosbuild1

@GitHuaKuang GitHuaKuang Awaiting requested review from GitHuaKuang

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sydneyvanda @daosbuild1 @byron-marohn @frostedcmos @SABollinger @jolivier23