DAOS-4855 debug: set default log mask to DLOG_ERR (#5174) #5235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default log mask was set to DLOG_INFO. This is harmless on server side since it will be overidden using log_mask parameter in config file. But on client side, now that default log stream is stdout since first PR-3048 for DAOS-4855, it causes unnecessary messages to be printed on interactive terminal. So set default log mask to DLOG_ERR instead and leave the choice to the user to change it using D_LOG_MASK environment variable. Change-Id: If9b89a81764734ccb11e712fb3efc6a442b2713a Signed-off-by: Bruno Faccini <bruno.faccini@intel.com>
daosbuild1
reviewed
Mar 30, 2021
johannlombardi
approved these changes
Mar 30, 2021
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default log mask was set to DLOG_INFO. This is harmless on
server side since it will be overidden using log_mask parameter
in config file. But on client side, now that default log stream
is stdout since first PR-3048 for DAOS-4855, it causes
unnecessary messages to be printed on interactive terminal.
So set default log mask to DLOG_ERR instead and leave the choice
to the user to change it using D_LOG_MASK environment variable.
Master-PR: #5174
Change-Id: If9b89a81764734ccb11e712fb3efc6a442b2713a
Signed-off-by: Bruno Faccini bruno.faccini@intel.com