Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update upnp_openports.sh #95

Merged
merged 8 commits into from
Dec 19, 2018
Merged

Update upnp_openports.sh #95

merged 8 commits into from
Dec 19, 2018

Conversation

sponnet
Copy link
Contributor

@sponnet sponnet commented Dec 17, 2018

Close default access to the host on the SSH port from outside of the network.

vdo
vdo suggested changes Dec 17, 2018
View reviewed changes
Copy link
Contributor

@vdo vdo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would comment line 8 too, so it doesn't close any 22 port.

@dapplion
Copy link
Contributor

Moving issue to review

@eduadiez eduadiez changed the base branch from master to dev December 19, 2018 15:52
@eduadiez eduadiez self-requested a review December 19, 2018 15:52
@eduadiez eduadiez merged commit 0dab418 into dappnode:dev Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdo vdo vdo requested changes

@eduadiez eduadiez Awaiting requested review from eduadiez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sponnet @dapplion @vdo @eduadiez