Skip to content

Conversation

@berndverst
Copy link
Member

In order to test the various authentication methods for KeyVault several credentials and component configurations need to be configured.

This PR makes the necessary changes.

@berndverst berndverst requested review from a team as code owners October 19, 2021 20:02
@berndverst
Copy link
Member Author

This PR can be verified like so:

bash setup-azure-conf-test.sh --user="XXXXX@microsoft.com" --location="WestUS2"
source $HOME/azure-conf-test/XXXXX-conf-test-config.rc
 go test -v -tags=conftests -count=1 ./tests/conformance -run="TestSecretStoreConformance/azure.keyvault.serviceprincipal"
 go test -v -tags=conftests -count=1 ./tests/conformance -run="TestSecretStoreConformance/azure.keyvault.certificate"

Note that you need to run in a particular environment with MSI enabled (and the identity having the correct permission) to run the remaining test:

 go test -v -tags=conftests -count=1 ./tests/conformance -run="TestSecretStoreConformance/azure.keyvault.managedidentity"

@berndverst
Copy link
Member Author

@CodeMonkeyLeet you previously suggested creating different configs for the different authentication mechanisms. Thoughts on this PR?

I am planning to call the new authentication methods as conformance tests via the new integration test framework (I will need to spin up the managed identity enabled environment from there), though I could also enable serviceprincipal auth directly via the test matrix here.

@berndverst
Copy link
Member Author

Removed the Managed Identity configuration from the conformance tests since it can't be run there. Will instead consider creating a sample / quickstart.

CodeMonkeyLeet
CodeMonkeyLeet previously approved these changes Oct 20, 2021
Copy link
Contributor

@CodeMonkeyLeet CodeMonkeyLeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #1206 (029ca1d) into master (b2752d0) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1206   +/-   ##
=======================================
  Coverage   35.07%   35.07%           
=======================================
  Files         147      147           
  Lines       12622    12624    +2     
=======================================
+ Hits         4427     4428    +1     
  Misses       7727     7727           
- Partials      468      469    +1     
Impacted Files Coverage Δ
tests/conformance/common.go 16.86% <0.00%> (-0.14%) ⬇️
state/cloudstate/cloudstate_crdt.go 9.09% <0.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4532359...029ca1d. Read the comment docs.

@daixiang0 daixiang0 merged commit 32d6083 into dapr:master Oct 20, 2021
amimimor pushed a commit to amimimor/components-contrib that referenced this pull request Dec 9, 2021
Integration test setup for AKV
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants