-
Notifications
You must be signed in to change notification settings - Fork 543
Integration test setup for AKV #1206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR can be verified like so: bash setup-azure-conf-test.sh --user="XXXXX@microsoft.com" --location="WestUS2"
source $HOME/azure-conf-test/XXXXX-conf-test-config.rc go test -v -tags=conftests -count=1 ./tests/conformance -run="TestSecretStoreConformance/azure.keyvault.serviceprincipal"
go test -v -tags=conftests -count=1 ./tests/conformance -run="TestSecretStoreConformance/azure.keyvault.certificate"Note that you need to run in a particular environment with MSI enabled (and the identity having the correct permission) to run the remaining test: go test -v -tags=conftests -count=1 ./tests/conformance -run="TestSecretStoreConformance/azure.keyvault.managedidentity" |
|
@CodeMonkeyLeet you previously suggested creating different configs for the different authentication mechanisms. Thoughts on this PR? I am planning to call the new authentication methods as conformance tests via the new integration test framework (I will need to spin up the managed identity enabled environment from there), though I could also enable serviceprincipal auth directly via the test matrix here. |
|
Removed the Managed Identity configuration from the conformance tests since it can't be run there. Will instead consider creating a sample / quickstart. |
CodeMonkeyLeet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #1206 +/- ##
=======================================
Coverage 35.07% 35.07%
=======================================
Files 147 147
Lines 12622 12624 +2
=======================================
+ Hits 4427 4428 +1
Misses 7727 7727
- Partials 468 469 +1
Continue to review full report at Codecov.
|
Integration test setup for AKV
In order to test the various authentication methods for KeyVault several credentials and component configurations need to be configured.
This PR makes the necessary changes.