Skip to content

Conversation

@theonefx
Copy link
Contributor

@theonefx theonefx commented Jun 3, 2021

Description

A state component which implemented by Alibaba Cloud TableStore.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #914

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@ghost
Copy link

ghost commented Jun 3, 2021

CLA assistant check
All CLA requirements met.

}

func (s *AliCloudTableStore) Get(req *state.GetRequest) (*state.GetResponse, error) {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line

func (s *AliCloudTableStore) BulkGet(reqs []state.GetRequest) (bool, []state.BulkGetResponse, error) {

if len(reqs) == 0 {
// "len == 0": empty request, directly return empty response
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put this onto L98

}

func (s *AliCloudTableStore) Set(req *state.SetRequest) error {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also delete.

}

func (s *AliCloudTableStore) Delete(req *state.DeleteRequest) error {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above.

}

func (s *AliCloudTableStore) Ping() error {
return nil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add TODO here.

package tablestore

import (
//"encoding/json"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove those unused line.

assert.Equal(t, "ENDPOINT", meta.Endpoint)
}

//func TestDataEncodeAndDecode(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove or enable.

@dapr-bot
Copy link
Collaborator

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot added the stale label Aug 26, 2021
@daixiang0
Copy link
Member

ping @theonefx

@dapr-bot dapr-bot removed the stale label Aug 30, 2021
@theonefx
Copy link
Contributor Author

theonefx commented Sep 2, 2021

my branch has some conflict so i open a new pr : #1116

@theonefx theonefx closed this Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Alibaba Cloud TableStore state

3 participants