-
Notifications
You must be signed in to change notification settings - Fork 543
Add state alicloud.tablestore #915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| } | ||
|
|
||
| func (s *AliCloudTableStore) Get(req *state.GetRequest) (*state.GetResponse, error) { | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this line
| func (s *AliCloudTableStore) BulkGet(reqs []state.GetRequest) (bool, []state.BulkGetResponse, error) { | ||
|
|
||
| if len(reqs) == 0 { | ||
| // "len == 0": empty request, directly return empty response |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put this onto L98
| } | ||
|
|
||
| func (s *AliCloudTableStore) Set(req *state.SetRequest) error { | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also delete.
| } | ||
|
|
||
| func (s *AliCloudTableStore) Delete(req *state.DeleteRequest) error { | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above.
| } | ||
|
|
||
| func (s *AliCloudTableStore) Ping() error { | ||
| return nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add TODO here.
| package tablestore | ||
|
|
||
| import ( | ||
| //"encoding/json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove those unused line.
| assert.Equal(t, "ENDPOINT", meta.Endpoint) | ||
| } | ||
|
|
||
| //func TestDataEncodeAndDecode(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove or enable.
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
ping @theonefx |
|
my branch has some conflict so i open a new pr : #1116 |
Description
A state component which implemented by Alibaba Cloud TableStore.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #914
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: