Add state alicloud.tablestore #1116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 2, 2021
Contributor
|
@theonefx Can you fix the linter issues in this PR? See inline in the "Files changed" tab. @artursouza & @daixiang0 FYI, since you reviewed a previous version of this PR before. |
Contributor
Author
|
@CodeMonkeyLeet no problem |
…trib into tablestore-state
Contributor
Author
|
@CodeMonkeyLeet Done |
daixiang0
reviewed
Sep 3, 2021
daixiang0
reviewed
Sep 3, 2021
daixiang0
reviewed
Sep 3, 2021
daixiang0
reviewed
Sep 3, 2021
daixiang0
reviewed
Sep 3, 2021
daixiang0
reviewed
Sep 3, 2021
daixiang0
reviewed
Sep 3, 2021
daixiang0
reviewed
Sep 3, 2021
daixiang0
reviewed
Sep 3, 2021
daixiang0
reviewed
Sep 3, 2021
daixiang0
reviewed
Sep 3, 2021
daixiang0
reviewed
Sep 3, 2021
daixiang0
reviewed
Sep 3, 2021
daixiang0
reviewed
Sep 3, 2021
Member
daixiang0
left a comment
daixiang0
left a comment
There was a problem hiding this comment.
Thanks for your contribution, some nits here and please try to add tests for all functions.
4 tasks
daixiang0
reviewed
Sep 17, 2021
daixiang0
reviewed
Sep 17, 2021
daixiang0
reviewed
Sep 17, 2021
|
|
||
| "github.com/golang/mock/gomock" | ||
|
|
||
| "github.com/agrea/ptr" |
Contributor
There was a problem hiding this comment.
@theonefx can you run goimports to fix this linter issue?
CodeMonkeyLeet
approved these changes
Sep 27, 2021
Contributor
CodeMonkeyLeet
left a comment
CodeMonkeyLeet
left a comment
There was a problem hiding this comment.
LGTM.
FYI @artursouza seems fine for alpha component, but looks like it will not pass conformance tests for Etag/concurrency handling as it moves into beta. Candidate for multicloud testing.
artursouza
approved these changes
Sep 28, 2021
Codecov Report
@@ Coverage Diff @@
## master #1116 +/- ##
==========================================
+ Coverage 33.77% 34.45% +0.68%
==========================================
Files 138 140 +2
Lines 11686 11890 +204
==========================================
+ Hits 3947 4097 +150
- Misses 7329 7375 +46
- Partials 410 418 +8
Continue to review full report at Codecov.
|
Taction
added a commit
to Taction/components-contrib
that referenced
this pull request
Oct 6, 2021
* master: fix 'durable' setting in RabbitMQ (dapr#1183) Support setting up Azure IoT Hub for integration testing with EventHubs components (dapr#1174) gcp bucket update (dapr#1128) ok-to-test changes for components-contrib (dapr#1091) version stored procedure due to previous changes made (dapr#1176) Fix existing integration tests (dapr#1173) Add state alicloud.tablestore (dapr#1116) Add dapr user agent for Azure Components (dapr#1152) Support using setup-azure-conf-test.sh with existing Service Principal (dapr#1158) Add Event Hubs conformance tests to conformance.yml workflow (dapr#1164) restructure code and add comments per code review cover all concurrency + etag cases Fix EOF linebreaks Adds first-write conformance test update metadata key fix linter warnings TableStorage conformance tests pass TableStore config tablestorage conformance WIP ci: standard linter config (dapr#1102) # Conflicts: # secretstores/hashicorp/vault/vault.go
amimimor
pushed a commit
to amimimor/components-contrib
that referenced
this pull request
Dec 9, 2021
* state alicloud.tablestore * some bug fix * gofumpt * add unit test * gofumpt * golangci-lint * code refactor * goimports * goimports Co-authored-by: Simon Leet <31784195+CodeMonkeyLeet@users.noreply.github.com> Co-authored-by: Long Dai <long0dai@foxmail.com> Co-authored-by: Long Dai <long.dai@intel.com> Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A state component which implemented by Alibaba Cloud TableStore.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #914
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: