gcp bucket update #1128
Merged
gcp bucket update #1128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/components-contrib into binding-gcp-bucket-update
Member
|
@beiwei30 can you please review this? |
Member
|
@fjvela please resolve the conflict and we'll move on to merging. thanks! |
Codecov Report
@@ Coverage Diff @@
## master #1128 +/- ##
==========================================
+ Coverage 33.77% 34.34% +0.56%
==========================================
Files 138 140 +2
Lines 11686 11993 +307
==========================================
+ Hits 3947 4119 +172
- Misses 7329 7450 +121
- Partials 410 424 +14
Continue to review full report at Codecov.
|
beiwei30
approved these changes
Sep 28, 2021
Member
beiwei30
left a comment
beiwei30
left a comment
There was a problem hiding this comment.
LGTM now, Thanks Javier for this effort.
Member
Taction
added a commit
to Taction/components-contrib
that referenced
this pull request
Oct 6, 2021
* master: fix 'durable' setting in RabbitMQ (dapr#1183) Support setting up Azure IoT Hub for integration testing with EventHubs components (dapr#1174) gcp bucket update (dapr#1128) ok-to-test changes for components-contrib (dapr#1091) version stored procedure due to previous changes made (dapr#1176) Fix existing integration tests (dapr#1173) Add state alicloud.tablestore (dapr#1116) Add dapr user agent for Azure Components (dapr#1152) Support using setup-azure-conf-test.sh with existing Service Principal (dapr#1158) Add Event Hubs conformance tests to conformance.yml workflow (dapr#1164) restructure code and add comments per code review cover all concurrency + etag cases Fix EOF linebreaks Adds first-write conformance test update metadata key fix linter warnings TableStorage conformance tests pass TableStore config tablestorage conformance WIP ci: standard linter config (dapr#1102) # Conflicts: # secretstores/hashicorp/vault/vault.go
amimimor
pushed a commit
to amimimor/components-contrib
that referenced
this pull request
Dec 9, 2021
* gcp bucket update create operation: support upload files in base64 * gcp bucket add get operation * gcp bucket add delete operation * gcp bucket add list operation * gcp bucket fix lint * gcp bucked add backward compatibility 'key' replace 'name' * gcp bucket fix lint * gcp bucket create operation return object url to download * gcp fix lint * gcp fix lint * gcp bucket fix lint * gcp bucket fix lint * gcp bucket fix error msg * rerun checks Co-authored-by: Yaron Schneider <yaronsc@microsoft.com> Co-authored-by: Long Dai <long0dai@foxmail.com> Co-authored-by: Ian Luo <ian.luo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update GCP Storage Bucket binding:
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1125
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: