ok-to-test changes for components-contrib #1091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/ok-to-test |
This reverts commit 2903695.
Contributor
CodeMonkeyLeet
left a comment
CodeMonkeyLeet
left a comment
There was a problem hiding this comment.
Looks generally okay except for the extra dispatch.
You should also merge from upstream master and resolve the conflict in your branch ... #1058 introduced the dapr-bot.yml already and your changes need to be reconciled with those which pulled in support for the /assign command.
3 tasks
Member
|
@artursouza please review |
artursouza
approved these changes
Sep 29, 2021
Codecov Report
@@ Coverage Diff @@
## master #1091 +/- ##
==========================================
+ Coverage 33.77% 34.45% +0.68%
==========================================
Files 138 140 +2
Lines 11686 11890 +204
==========================================
+ Hits 3947 4097 +150
- Misses 7329 7375 +46
- Partials 410 418 +8
Continue to review full report at Codecov.
|
3 tasks
Taction
added a commit
to Taction/components-contrib
that referenced
this pull request
Oct 6, 2021
* master: fix 'durable' setting in RabbitMQ (dapr#1183) Support setting up Azure IoT Hub for integration testing with EventHubs components (dapr#1174) gcp bucket update (dapr#1128) ok-to-test changes for components-contrib (dapr#1091) version stored procedure due to previous changes made (dapr#1176) Fix existing integration tests (dapr#1173) Add state alicloud.tablestore (dapr#1116) Add dapr user agent for Azure Components (dapr#1152) Support using setup-azure-conf-test.sh with existing Service Principal (dapr#1158) Add Event Hubs conformance tests to conformance.yml workflow (dapr#1164) restructure code and add comments per code review cover all concurrency + etag cases Fix EOF linebreaks Adds first-write conformance test update metadata key fix linter warnings TableStorage conformance tests pass TableStore config tablestorage conformance WIP ci: standard linter config (dapr#1102) # Conflicts: # secretstores/hashicorp/vault/vault.go
3 tasks
amimimor
pushed a commit
to amimimor/components-contrib
that referenced
this pull request
Dec 9, 2021
* eventhubs metadata propagation * ok-to-test changes * Revert "eventhubs metadata propagation" This reverts commit 2903695. * ok-to-test changes based on review Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you've made
Issue reference #1070
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: