Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for Per Actor Type Configuration #857

Closed
halspang opened this issue Apr 7, 2022 · 0 comments · Fixed by #870
Closed

Add Support for Per Actor Type Configuration #857

halspang opened this issue Apr 7, 2022 · 0 comments · Fixed by #870
Assignees
@halspang
Milestone
v1.8

Comments

@halspang
Copy link
Contributor

halspang commented Apr 7, 2022

Describe the proposal

The Dapr Runtime added support for per actor type configurations in 1.7. This support needs to be added to the SDKs.

The new configuration looks like:

{
  "entities":["actorType1", "actorType2"],
  "actorIdleTimeout": "1h",
  "actorScanInterval": "30s",
  "drainOngoingCallTimeout": "30s",
  "drainRebalancedActors": true,
  "reentrancy": {
    "enabled": true,
    "maxStackDepth": 32
  },
  "entitiesConfig": [
      {
          "entities": ["actorType1"],
          "actorIdleTimeout": "1m",
          "drainOngoingCallTimeout": "10s",
          "reentrancy": {
              "enabled": false
          }
      }
  ]
}

Implementation can be varied per SDK but should output to the above JSON.

Docs: dapr/docs#2334
Runtime: dapr/dapr#4201
@halspang halspang added this to the v1.8 milestone Apr 8, 2022
@halspang halspang self-assigned this Apr 29, 2022
halspang added a commit to halspang/dotnet-sdk that referenced this issue Apr 29, 2022
@halspang
Add support for per type actor configuration
b51ad18 
This commit allows different actor types to provide their own
configurations instead of relying on the top-level values. Any
value defined in them will be used instead of the top-level.
Anything that is left out will use the top-level or default if
it is undefined.

dapr#857

Signed-off-by: Hal Spang <halspang@microsoft.com>
@halspang halspang mentioned this issue Apr 29, 2022
Merged
3 tasks
halspang added a commit that referenced this issue May 26, 2022
@halspang
Add support for per type actor configuration (#870)
e4236c4 
This commit allows different actor types to provide their own
configurations instead of relying on the top-level values. Any
value defined in them will be used instead of the top-level.
Anything that is left out will use the top-level or default if
it is undefined.

#857

Signed-off-by: Hal Spang <halspang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@halspang halspang

Labels
None yet
Projects
None yet
Milestone
v1.8
Development

Successfully merging a pull request may close this issue.

Add support for per type actor configuration halspang/dotnet-sdk
1 participant
@halspang