-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/476 multiple methods per interface with JSON serialization doesn´t work #1343
base: master
Are you sure you want to change the base?
Bug/476 multiple methods per interface with JSON serialization doesn´t work #1343
Conversation
I did found out what is wrong with the devcontainer setup :) Will fix both here. Of course the blind implementation was broken. Will be fixed in the next hour. |
f847e87
to
a13100b
Compare
@onionhammer This is now ready to review :) That was a fun research. I tried to don't break existing code paths as much as I could. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, although I have no authority here :)
.NET 7 fell out of support May 14 of this year and .NET 8 will do the same on November 10, 2024 with .NET 9 being introduced in the same time frame. That should be right around the 1.15 release, so I think there will be a good case to be made to drop .NET 6 and .NET 7 explicit support, target .NET 8 instead and include .NET 9 in the test suite for 1.16. |
Signed-off-by: paule96 <paul-jeschke@outlook.com>
Signed-off-by: paule96 <paul-jeschke@outlook.com>
…terface Signed-off-by: paule96 <paul-jeschke@outlook.com>
Now the devcontainer uses docker in docker, so you can reach the dapr setup after you did run dapr init. This will then only affect the dev container, without compromising the host of the devcontainer Signed-off-by: paule96 <paul-jeschke@outlook.com>
Signed-off-by: paule96 <paul-jeschke@outlook.com>
Signed-off-by: paule96 <paul-jeschke@outlook.com>
Signed-off-by: paule96 <paul-jeschke@outlook.com>
Signed-off-by: paule96 <paul-jeschke@outlook.com>
adb8471
to
7be9077
Compare
@WhitWaldo if I change the default version to dotnet 9.0 the new security vulnerability scanning of the dotnet CLI turns on implicitly and produces, of course, a lot of errors. I guess the upgrading of the default SDK needs to be delayed. maybe a separate issue is needed to clean up the solution of, the old tests, old implementation, and what else is connected to it. I guess the documentation needs to be updated too. So for now I would try to just update the default to dotnet 8.0 (support until November 10, 2026, it's LTS), and postpone the change to dotnet 9.0 to a later point in time. |
That's right - the plan is to put off changing the targeted releases until after the release of Dapr 1.15. There, we'll target .NET 6 and .NET 8 still, so no changes needed in the short term. But we'll put something prominent announcing EOL in the release notes so it's clear that in 1.16 we'll drop support for .NET 6 in favor of .NET 8 (and language version C# 12). An open question on that thread is whether we should go on targeting .NET 9 as well (though I'm also inclined to lean yes since there are frequently so many performance improvements in each). You're right, that'll require some significant doc updates in addition to the other projects, but I've got a draft PR that'll likely handle the latter as I'm gradually adding nullability annotations throughout the .NET SDK and there are several other PRs in place that'll shift up some of the project layouts as well that'll help. Things to tackle after the next release! |
@WhitWaldo do you know anybody I could ping to get a review? (maybe yourself) |
@paule96 I'm not a maintainer, so my check isn't worth a whole lot. I suspect this will get more attention as we edge closer to the 1.15 release and there's more of a general code freeze. If it hasn't been looked at closer to that timeline, I'll give it a look myself (for whatever it might be worth). |
…h_json_serialisation_doesntwork
Description
Now the Actor manager provides the
MethodName
for the serializationActorMessageSerializersManager
.This makes it now possible for the JSON serialization to support Actor interfaces with more than one method defined in it.
As a side effect, this PR solves #1342 too.
Changes made in the dev container:
C# DevKit
as an additional extension. This can be a breaking change for people that don't have a visual studio license and want to run the dev container on their local host. Users that run the dev container on GitHub get a license automatically injected.localinit.sh
script before running itIssue reference
It's part of the issue #476 starting with this comment.
It fixes also #1342
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
cc @onionhammer as original contributor :)