Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose underlying grpc client #204

Closed
drewwells opened this issue Sep 23, 2021 · 0 comments · Fixed by #311
Closed

Expose underlying grpc client #204

drewwells opened this issue Sep 23, 2021 · 0 comments · Fixed by #311
Labels
enhancement New feature or request

Comments

@drewwells
Copy link

Is your feature request related to a problem? Please describe.
I want to implement metadata support which is already available in the underlying grpc client but puzzling missing from the wrapped Client interface.

This is easy to implement by copy/pasting the PublishClient code, but I'm unable to retrieve a grpc client to use. So instead, I'll need to implement my own to call the grpc interface.

Describe the solution you'd like
It would be easier if Client interface supported retrieving the grpc client it uses.

Describe alternatives you've considered
Write my own client interface that just uses the grpc client directly.
@drewwells drewwells added the enhancement New feature or request label Sep 23, 2021
ItalyPaleAle added a commit to ItalyPaleAle/dapr-go-sdk that referenced this issue Aug 8, 2022
@ItalyPaleAle
Expose underlying gRPC client and server objects
865a1a3 
Fixes dapr#204

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
@ItalyPaleAle ItalyPaleAle mentioned this issue Aug 8, 2022
Merged
yaron2 pushed a commit that referenced this issue Sep 30, 2022
@ItalyPaleAle
Expose underlying gRPC client and server objects (#311)
cfd7483 
* Expose underlying gRPC client and server objects

Fixes #204

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

* Fixed reported race conditions

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

* Support for Go 1.17

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose underlying gRPC client and server objects ItalyPaleAle/dapr-go-sdk
1 participant
@drewwells