chore: remove the binary and add gitignore #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #315 +/- ##
=======================================
Coverage 67.22% 67.22%
=======================================
Files 27 27
Lines 1547 1547
=======================================
Hits 1040 1040
Misses 418 418
Partials 89 89 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: 117503445 <t117503445@gmail.com>
117503445
force-pushed
the
chore-ignore-bin
branch
from
c0f3cff
to
11101fe
Compare
|
@mukundansundar Do you need to review it? |
yaron2
approved these changes
Oct 1, 2022
|
Thanks @117503445 |
wXwcoder
pushed a commit
to wXwcoder/go-sdk
that referenced
this pull request
Nov 14, 2022
Signed-off-by: 117503445 <t117503445@gmail.com> Signed-off-by: 117503445 <t117503445@gmail.com> Signed-off-by: wangxw <996268132@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is associated with issues #314.
This PR removes binaries and adds gitignore to prevent accidentally adding binaries next time. This PR also fixes a build issue with the socket example.