Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dapr in Testcontainers should use a wait strategy based on healthz/outbound #1104

Closed
artur-ciocanu opened this issue Aug 16, 2024 · 0 comments · Fixed by #1105
Closed

Dapr in Testcontainers should use a wait strategy based on healthz/outbound #1104

artur-ciocanu opened this issue Aug 16, 2024 · 0 comments · Fixed by #1105
Labels
kind/bug Something isn't working

Comments

@artur-ciocanu
Copy link
Contributor

Expected Behavior

Currently we could run into race conditions when using Dapr Testcontainer implementation when it is used across multiple integration tests. We should use Testcontainers Wait Strategy to make sure that container is marked as ready ONLY when all the components are properly initialized.

Actual Behavior

There tests based on current Dapr Testcontainer could run into random failures because of race conditions when running the containers, since there is no explicit waiting to make sure container is properly initialized.

Steps to Reproduce the Problem

Create a few tests using Dapr Testcontainers and see how tests fail randomly.

Release Note

RELEASE NOTE:

@artur-ciocanu artur-ciocanu added the kind/bug Something isn't working label Aug 16, 2024
artur-ciocanu added a commit to artur-ciocanu/java-sdk that referenced this issue Aug 22, 2024
artur-ciocanu added a commit to artur-ciocanu/java-sdk that referenced this issue Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant