Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Dapr Container default wait strategy based on healthz/outbound #1105

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

artur-ciocanu
Copy link
Contributor

Description

Adding Dapr Container default wait strategy based on healthz/outbound

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1104

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@artur-ciocanu artur-ciocanu requested review from a team as code owners August 16, 2024 10:56
@artur-ciocanu
Copy link
Contributor Author

@artursouza and @cicoyle could you please take a look. This is required to make sure that we declare Dapr Testcontainer ready only when all the components are initialized.

Thank you!

Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>
Copy link
Member

@artursouza artursouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment. LGTM.

sdk-tests/pom.xml Outdated Show resolved Hide resolved
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>
@artur-ciocanu
Copy link
Contributor Author

Just a minor comment. LGTM.

Fixed.

@artur-ciocanu
Copy link
Contributor Author

@artursouza and @cicoyle the PR has been adjusted. The Validate Examples failed because of some Docker Compose diff in output. I haven't touched any of that. It would be good to see if we can re-trigger the build, to ensure things look good and merge the PR.

Copy link
Contributor

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@artursouza artursouza merged commit a6923ed into dapr:master Aug 26, 2024
7 checks passed
@cicoyle cicoyle added this to the v1.13 milestone Aug 26, 2024
@artur-ciocanu artur-ciocanu deleted the gh-1104 branch August 27, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dapr in Testcontainers should use a wait strategy based on healthz/outbound
3 participants