Ensure checkstyle can be imported into IDE #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>
|
@artursouza and @cicoyle this is a very, very, very boring PR, but without it developer experience was suboptimal. I had to fight the IDE and checkstyle to ensure the formatting is consistent. After this PR is merged anyone will be able to import into IDE and have proper code style. |
|
@artursouza @cicoyle we need this, so our IDEs format and check style on save :) |
|
This seems to be working as expected.. a random test seems to be failing. |
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>
cicoyle
approved these changes
Jul 19, 2024
artursouza
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades Checkstyle plugin to latest
10.17.0and makes sure thatcheckstyle.xmlis fixed so it can be imported into IDE like IntelliJ. This should ensure that anyone can use IDE to correctly format the code and ensure consistent code style.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1082
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: