Ensure we use the same GRPC version everywhere #1137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>
Contributor
Author
|
@artursouza and @cicoyle this another tiny PR that should make our life easier, since having two GRPC versions on the classpath can lead to "interesting" issues. If everything looks good, please approve and merge. Thank you 🙇 |
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>
salaboy
reviewed
Sep 24, 2024
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>
Contributor
Author
|
@salaboy @cicoyle @artursouza I have addressed the PR comments. Could you please take another look. Thank you! |
cicoyle
previously approved these changes
Sep 25, 2024
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>
artursouza
previously approved these changes
Sep 25, 2024
cicoyle
previously approved these changes
Sep 25, 2024
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>
artur-ciocanu
dismissed stale reviews from cicoyle and artursouza
via
529db5a
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>
Contributor
Author
|
@artursouza and @cicoyle would you be so kind to approve one more time. I have tried a few things to ensure the failing test passes. Thank you. |
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>
Contributor
Author
|
@artursouza @salaboy and @cicoyle the build is finally 🟢 could you please approve and merge. Thank you! 🙇 |
cicoyle
approved these changes
Sep 26, 2024
artursouza
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure we use the same GRPC version everywhere
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1136
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: