Updating docs to have spring boot 3.x banner and not hardcoded deps #1366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: salaboy <Salaboy@gmail.com>
siri-varma
approved these changes
May 15, 2025
cicoyle
reviewed
May 15, 2025
Signed-off-by: salaboy <Salaboy@gmail.com>
siri-varma
reviewed
May 19, 2025
|
@salaboy could you please review the last comment from @siri-varma and @cicoyle, so we could merge this PR. |
Adding links to discord and github issues Signed-off-by: salaboy <Salaboy@gmail.com>
|
All comments done @dapr/maintainers-java-sdk please re-review |
cicoyle
approved these changes
May 22, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1366 +/- ##
============================================
+ Coverage 76.91% 78.12% +1.20%
- Complexity 1592 1831 +239
============================================
Files 145 223 +78
Lines 4843 5663 +820
Branches 562 601 +39
============================================
+ Hits 3725 4424 +699
- Misses 821 919 +98
- Partials 297 320 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
siri-varma
pushed a commit
to siri-varma/java-sdk
that referenced
this pull request
Aug 6, 2025
…apr#1366) * updating docs to have spring boot 3.x banner and not hardcoded deps Signed-off-by: salaboy <Salaboy@gmail.com> * Update _index.md Signed-off-by: salaboy <Salaboy@gmail.com> * Update _index.md Adding links to discord and github issues Signed-off-by: salaboy <Salaboy@gmail.com> --------- Signed-off-by: salaboy <Salaboy@gmail.com> Co-authored-by: artur-ciocanu <artur.ciocanu@gmail.com> Signed-off-by: sirivarma <siri.varma@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding banner at the top about Spring Boot 3.x version requirement and removing hardcoded version, in favor of having a link to find the latest release.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1365
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: