Initial Workflow SDK #857

bderusha · 2023-05-11T14:55:23Z

Description

This PR covers just enough of the authoring and management APIs to allow for anyone to be able to add the rest of them without requiring much/any coordination around structure.

Design decisions of note:

sdk-workflows is implemented as a separate optional package (like actors)
Runtime registration follows conventions/patterns used by sdk-actors with WorkflowRuntime.getInstance().registerWorkflow(...)

Warning
Bug Alert:
Ran into a panic: runtime error: invalid memory address or nil pointer dereference error while using durabletask-java@v1.1.0 with dapr runtime 1.10.7. It seems to be related to some mismatch between the client and the durabletask-go@v0.1.3 that comes with dapr 1.10. When run against dapr runtime 1.11.0-rc.1 everything works nicely.

Issue reference

#839

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Code compiles correctly
Created/updated tests
Extended the documentation

nyemade-uversky · 2023-05-15T23:28:54Z

Putting this on our radars @cgillum , @DeepanshuA , @RyanLettieri

bderusha · 2023-05-23T13:12:33Z

@cgillum , @DeepanshuA , @RyanLettieri, @nyemade-uversky This PR is almost done in terms of foundations. Would love a quick review before we add a bunch more methods if you have time this week.

Signed-off-by: Bill DeRusha <billderusha@microsoft.com>

Signed-off-by: Hannah Kennedy <hakenned@microsoft.com>

cgillum

This is a great start! Some comments below.

examples/src/main/java/io/dapr/examples/workflows/DemoWorkflow.java

sdk-workflows/src/main/java/io/dapr/workflows/runtime/WorkflowRuntime.java

examples/src/main/java/io/dapr/examples/workflows/DemoWorkflowService.java

sdk-workflows/src/main/java/io/dapr/workflows/client/DaprWorkflowClient.java

sdk-workflows/src/main/java/io/dapr/workflows/runtime/WorkflowContext.java

sdk-workflows/pom.xml

Signed-off-by: Bill DeRusha <444835+bderusha@users.noreply.github.com>

bderusha · 2023-06-01T19:39:56Z

@cgillum Thanks for the feedback! I pushed up a new round of changes to address them

cgillum

A few additional comments/questions.

sdk-workflows/src/main/java/io/dapr/workflows/runtime/DaprWorkflowContextImpl.java

sdk-workflows/src/main/java/io/dapr/workflows/runtime/WorkflowRuntime.java

examples/src/main/java/io/dapr/examples/workflows/DemoWorkflowClient.java

sdk-workflows/src/test/java/io/dapr/workflows/runtime/DaprWorkflowContextImplTest.java

Signed-off-by: Bill DeRusha <444835+bderusha@users.noreply.github.com>

bderusha · 2023-06-02T15:47:27Z

Thanks for the quick turnaround, @cgillum. I believe I have addressed all active comments. Let me know if you have any more suggestions.

Signed-off-by: Bill DeRusha <444835+bderusha@users.noreply.github.com>

cgillum

Just a few small things/questions.

sdk-workflows/src/main/java/io/dapr/workflows/runtime/DaprWorkflowContextImpl.java

sdk-workflows/src/main/java/io/dapr/workflows/runtime/OrchestratorWrapper.java

sdk-workflows/src/main/java/io/dapr/workflows/runtime/WorkflowRuntime.java

bderusha · 2023-06-06T18:13:10Z

Thanks @cgillum Pushed up a quick set of changes based on your feedback.

Is there anyone else we need to loop into this PR for it to land? It feels like we're getting close here

cgillum · 2023-06-06T22:42:42Z

@bderusha this PR looks good to me. However, I don't have permissions to merge it as I'm not a maintainer for the Dapr Java SDK (my signoffs don't count either). We'll need @dapr/approvers-java-sdk and @dapr/maintainers-java-sdk to take a look.

FYI @nyemade-uversky in case we need to ping relevant folks directly.

johnewart

Looks like a good start! I just had a few comments about dependencies that were added to POMs (looks like perhaps dependencies got added in places they don't need to be).

examples/pom.xml

pom.xml

Signed-off-by: Bill DeRusha <444835+bderusha@users.noreply.github.com>

bderusha · 2023-06-07T13:56:40Z

Looks like a good start! I just had a few comments about dependencies that were added to POMs (looks like perhaps dependencies got added in places they don't need to be).

Thanks @johnewart. Good catch on those dependencies. Should be all set now.

nyemade-uversky · 2023-06-07T18:23:16Z

@dapr/maintainers-java-sdk would you be able to take a look at this PR?

olitomlinson · 2023-06-09T14:01:40Z

@cgillum I don't know if this is the time or the place, but can I ask that code examples are included that demonstrate how to unit test a Workflow from an end users perspective i.e how to mock Activity calls, timers, continueAsNew etc etc

bderusha · 2023-06-26T13:38:21Z

@artursouza @mukundansundar Could you help trigger build again, please? I think I have resolved all the build issues now

nyemade-uversky · 2023-06-27T15:34:42Z

@artursouza, @mukundansundar and @bderusha would it be possible to get this PR merged this week? Looks like we're waiting on the build to pass, is that the only ting blocking this pr rn?

bderusha · 2023-06-27T20:53:25Z

@artursouza, @mukundansundar and @bderusha would it be possible to get this PR merged this week? Looks like we're waiting on the build to pass, is that the only ting blocking this pr rn?

@nyemade-uversky There is a single failing test for Build jdk:11 sb:2.5.7 around pub/sub. I have some time carved out to investigate tomorrow, but if anyone has time or insights to share I would welcome them.

bderusha · 2023-06-28T16:43:41Z

Thank you for rerunning the tests @mukundansundar Looks like that failure was intermittent. All tests are passing now.

FYI @nyemade-uversky

artursouza

This is great. I have provided some feedback.

Overall, I think it should be built using more of the main SDK connectivity - otherwise it will require duplication of code to handle connection to sidecar.

Last but not least, please, consider making this a separate project under dapr-sandbox org - instructions at https://github.com/dapr-sandbox/

I do think I should continue helping in the review to keep consistent user experience for the Java SDKs since not all decisions are documented.

examples/pom.xml

sdk-workflows/src/main/java/io/dapr/workflows/client/DaprWorkflowClient.java

sdk-workflows/src/main/java/io/dapr/workflows/runtime/DaprWorkflowContextImpl.java

sdk-workflows/src/main/java/io/dapr/workflows/runtime/Workflow.java

sdk-workflows/src/main/java/io/dapr/workflows/runtime/WorkflowContext.java

sdk-workflows/src/main/java/io/dapr/workflows/runtime/WorkflowRuntime.java

bderusha · 2023-06-30T21:02:12Z

This is great. I have provided some feedback.

Overall, I think it should be built using more of the main SDK connectivity - otherwise it will require duplication of code to handle connection to sidecar.

Last but not least, please, consider making this a separate project under dapr-sandbox org - instructions at https://github.com/dapr-sandbox/

I do think I should continue helping in the review to keep consistent user experience for the Java SDKs since not all decisions are documented.

@artursouza Thank you for the feedback. The code comments all make sense. I am curious to learn more about dapr-sandbox
though. Can you help me understand more about why this feature is a good fit for a sandbox project?

The context I am thinking about here is that other SDKs have early workflow support in their main repos (python-sdk, dotnet-sdk) and of course the workflow engine itself is in the mainline dapr/dapr.

At first blush it feels like this feature is no different from other alpha APIs introduced to the dapr runtime and then supported by the SDKs. But I am admittedly just learning about the dapr-sandbox so you may have additional context that draws a clearer line to why the sandbox is a good home. Regardless of where this code lands, I am interested in learning more so that we can streamline future contributions :) Thanks!

FYI I will be on vacation most of July and slow to respond, so I am tagging others who might be interested in this while I'm out.
@nyemade-uversky @cgillum @NarmathaBala

artursouza · 2023-07-03T17:29:38Z

This is great. I have provided some feedback.
Overall, I think it should be built using more of the main SDK connectivity - otherwise it will require duplication of code to handle connection to sidecar.
Last but not least, please, consider making this a separate project under dapr-sandbox org - instructions at https://github.com/dapr-sandbox/
I do think I should continue helping in the review to keep consistent user experience for the Java SDKs since not all decisions are documented.

@artursouza Thank you for the feedback. The code comments all make sense. I am curious to learn more about dapr-sandbox though. Can you help me understand more about why this feature is a good fit for a sandbox project?

The context I am thinking about here is that other SDKs have early workflow support in their main repos (python-sdk, dotnet-sdk) and of course the workflow engine itself is in the mainline dapr/dapr.

At first blush it feels like this feature is no different from other alpha APIs introduced to the dapr runtime and then supported by the SDKs. But I am admittedly just learning about the dapr-sandbox so you may have additional context that draws a clearer line to why the sandbox is a good home. Regardless of where this code lands, I am interested in learning more so that we can streamline future contributions :) Thanks!

FYI I will be on vacation most of July and slow to respond, so I am tagging others who might be interested in this while I'm out. @nyemade-uversky @cgillum @NarmathaBala

Making this a dapr-sandbox repo would need to be consistent with other SDKs, so all of them would move the WF part to it. In this case, there is a different since it is for composing workflow and not simply an Alpha API. The wf invocation is a simple Alpha API and it should still be here.

The main driving factor for this is that this is at a different maturity level and a new artifact. The fact that it is versioned differently from the other artifacts of the SDK says it all. That is why I am leaning torwards this being a separate SDK. For this to be merged in this repo, we would also need to update all the release scripts to handle specific versioning for this artifact. See https://github.com/dapr/java-sdk/wiki/Release-Process

artursouza · 2023-07-05T16:28:52Z

/cc @brunoborges do you mind taking a look at this PR too? It is from Msft.

NarmathaBala · 2023-07-11T18:36:21Z

This is great. I have provided some feedback.
Overall, I think it should be built using more of the main SDK connectivity - otherwise it will require duplication of code to handle connection to sidecar.
Last but not least, please, consider making this a separate project under dapr-sandbox org - instructions at https://github.com/dapr-sandbox/
I do think I should continue helping in the review to keep consistent user experience for the Java SDKs since not all decisions are documented.

@artursouza Thank you for the feedback. The code comments all make sense. I am curious to learn more about dapr-sandbox though. Can you help me understand more about why this feature is a good fit for a sandbox project?
The context I am thinking about here is that other SDKs have early workflow support in their main repos (python-sdk, dotnet-sdk) and of course the workflow engine itself is in the mainline dapr/dapr.
At first blush it feels like this feature is no different from other alpha APIs introduced to the dapr runtime and then supported by the SDKs. But I am admittedly just learning about the dapr-sandbox so you may have additional context that draws a clearer line to why the sandbox is a good home. Regardless of where this code lands, I am interested in learning more so that we can streamline future contributions :) Thanks!
FYI I will be on vacation most of July and slow to respond, so I am tagging others who might be interested in this while I'm out. @nyemade-uversky @cgillum @NarmathaBala

Making this a dapr-sandbox repo would need to be consistent with other SDKs, so all of them would move the WF part to it. In this case, there is a different since it is for composing workflow and not simply an Alpha API. The wf invocation is a simple Alpha API and it should still be here.

The main driving factor for this is that this is at a different maturity level and a new artifact. The fact that it is versioned differently from the other artifacts of the SDK says it all. That is why I am leaning torwards this being a separate SDK. For this to be merged in this repo, we would also need to update all the release scripts to handle specific versioning for this artifact. See https://github.com/dapr/java-sdk/wiki/Release-Process

@artursouza - @nyemade-uversky shared with us re: letting this PR merge into the Dapr repo. We have Bill out of office for the month of July. Considering the feedback suggested will involved some deep changes, we (Bill and I) agreed that it was best for Bill to pick this back up in August. I hope that works for the team.

brunoborges · 2023-07-18T20:54:11Z

/cc @brunoborges do you mind taking a look at this PR too? It is from Msft.

Hey Artur, sorry but I'm afraid I don't have the necessary knowledge of the Dapr SDK, nor the time, to provide meaningful feedback here.

craprivatebeta · 2023-07-20T16:02:21Z

This is great. I have provided some feedback.
Overall, I think it should be built using more of the main SDK connectivity - otherwise it will require duplication of code to handle connection to sidecar.
Last but not least, please, consider making this a separate project under dapr-sandbox org - instructions at https://github.com/dapr-sandbox/
I do think I should continue helping in the review to keep consistent user experience for the Java SDKs since not all decisions are documented.

@artursouza Thank you for the feedback. The code comments all make sense. I am curious to learn more about dapr-sandbox though. Can you help me understand more about why this feature is a good fit for a sandbox project?
The context I am thinking about here is that other SDKs have early workflow support in their main repos (python-sdk, dotnet-sdk) and of course the workflow engine itself is in the mainline dapr/dapr.
At first blush it feels like this feature is no different from other alpha APIs introduced to the dapr runtime and then supported by the SDKs. But I am admittedly just learning about the dapr-sandbox so you may have additional context that draws a clearer line to why the sandbox is a good home. Regardless of where this code lands, I am interested in learning more so that we can streamline future contributions :) Thanks!
FYI I will be on vacation most of July and slow to respond, so I am tagging others who might be interested in this while I'm out. @nyemade-uversky @cgillum @NarmathaBala

Making this a dapr-sandbox repo would need to be consistent with other SDKs, so all of them would move the WF part to it. In this case, there is a different since it is for composing workflow and not simply an Alpha API. The wf invocation is a simple Alpha API and it should still be here.
The main driving factor for this is that this is at a different maturity level and a new artifact. The fact that it is versioned differently from the other artifacts of the SDK says it all. That is why I am leaning torwards this being a separate SDK. For this to be merged in this repo, we would also need to update all the release scripts to handle specific versioning for this artifact. See https://github.com/dapr/java-sdk/wiki/Release-Process

@artursouza - @nyemade-uversky shared with us re: letting this PR merge into the Dapr repo. We have Bill out of office for the month of July. Considering the feedback suggested will involved some deep changes, we (Bill and I) agreed that it was best for Bill to pick this back up in August. I hope that works for the team.

That works for me. Yes, the PR can be added here.

mukundansundar · 2023-08-01T17:03:35Z

@NarmathaBala @bderusha
Do we have an ETA for updates in this PR? Thanks.

bderusha · 2023-08-02T13:41:52Z

@NarmathaBala @bderusha Do we have an ETA for updates in this PR? Thanks.

@mukundansundar I just got back from some time off and am planning to make progress on the PR this week.

Signed-off-by: Bill DeRusha <444835+bderusha@users.noreply.github.com>

bderusha · 2023-08-03T15:55:03Z

@mukundansundar @artursouza I believe I have addressed all outstanding comments. Please take a look when you get a chance.

Signed-off-by: Bill DeRusha <444835+bderusha@users.noreply.github.com>

skyao

it is a gread PR!

I put some very detail comments about the code implementation.

Let's make it perfect.

sdk-workflows/src/main/java/io/dapr/workflows/client/DaprWorkflowClient.java

sdk-workflows/src/test/java/io/dapr/workflows/client/DaprWorkflowClientTest.java

sdk/src/main/java/io/dapr/utils/NetworkUtils.java

sdk-workflows/pom.xml

sdk-workflows/src/main/java/io/dapr/workflows/runtime/OrchestratorWrapper.java

sdk-workflows/src/main/java/io/dapr/workflows/runtime/Workflow.java

sdk-workflows/src/main/java/io/dapr/workflows/runtime/WorkflowRuntime.java

Signed-off-by: Bill DeRusha <444835+bderusha@users.noreply.github.com>

examples/pom.xml

examples/src/main/java/io/dapr/examples/workflows/DemoWorkflow.java

sdk-workflows/pom.xml

sdk-workflows/src/main/java/io/dapr/workflows/DaprWorkflowContextImpl.java

sdk-workflows/src/main/java/io/dapr/workflows/Workflow.java

sdk-workflows/src/main/java/io/dapr/workflows/WorkflowContext.java

sdk-workflows/src/main/java/io/dapr/workflows/client/DaprWorkflowClient.java

artursouza · 2023-08-08T21:46:54Z

sdk-workflows/src/main/java/io/dapr/workflows/runtime/OrchestratorWrapper.java

+  }
+
+  @Override
+  public TaskOrchestration create() {


If all the API is blocking for DurableTask, then ProjectReactor does not add any value and makes things more complicated by giving the illusion of async model. Does DurableTask have an async API or is it all blocking?

@artursouza DurableTask does not expose any async methods in the client or runtime. The only async API is for some of the Orchestration and Activity Context classes which return custom Task classes which wrap java.util.concurrent.CompletableFuture objects.

I am new to ProjectReactor, so I don't have a good sense for effort VS value of trying to convert those context methods to mono. What are your thoughts?

DurableTask does not expose any async methods in the client or runtime.

This is so bad! So since DurableTask is blocking, then we use reactor in java sdk won't bring any value but make it complex.

It seems that we need to give up Mono and use normal blocking call.

I agree. We should keep it blocking until the DurableTask SDK addresses this: microsoft/durabletask-java#160

sdk-workflows/src/main/java/io/dapr/workflows/runtime/WorkflowRuntime.java

Signed-off-by: Bill DeRusha <444835+bderusha@users.noreply.github.com>

codecov · 2023-08-10T21:03:07Z

Codecov Report

Merging #857 (904e41e) into master (9dc842f) will increase coverage by 0.18%.
The diff coverage is 79.61%.

@@             Coverage Diff              @@
##             master     #857      +/-   ##
============================================
+ Coverage     77.31%   77.49%   +0.18%     
- Complexity     1268     1304      +36     
============================================
  Files           117      123       +6     
  Lines          3927     4013      +86     
  Branches        468      472       +4     
============================================
+ Hits           3036     3110      +74     
- Misses          652      662      +10     
- Partials        239      241       +2

Files Changed	Coverage Δ
...dapr/workflows/runtime/WorkflowRuntimeBuilder.java	`45.45% <45.45%> (ø)`
...io/dapr/workflows/runtime/OrchestratorWrapper.java	`64.70% <64.70%> (ø)`
...ava/io/dapr/workflows/runtime/WorkflowRuntime.java	`69.23% <69.23%> (ø)`
sdk/src/main/java/io/dapr/utils/NetworkUtils.java	`88.46% <81.25%> (-11.54%)`	⬇️
...a/io/dapr/workflows/client/DaprWorkflowClient.java	`91.30% <91.30%> (ø)`
...ava/io/dapr/workflows/DaprWorkflowContextImpl.java	`100.00% <100.00%> (ø)`
...lows/src/main/java/io/dapr/workflows/Workflow.java	`100.00% <100.00%> (ø)`
...rc/main/java/io/dapr/client/DaprClientBuilder.java	`71.42% <100.00%> (+6.72%)`	⬆️

... and 1 file with indirect coverage changes

bderusha mentioned this pull request May 11, 2023

Workflow implementation in SDK #839

Closed

cgillum mentioned this pull request May 26, 2023

Dapr Workflow Java SDK #870

Closed

bderusha changed the title ~~[WIP] Initial Workflow SDK design~~ Initial Workflow SDK May 26, 2023

mindlessroman force-pushed the master branch from 03e5445 to f93d3b2 Compare May 26, 2023 20:55

Init for workflows

ccd29fc

Signed-off-by: Bill DeRusha <billderusha@microsoft.com>

mindlessroman force-pushed the master branch from 72ccffd to ccd29fc Compare May 26, 2023 21:08

bderusha marked this pull request as ready for review May 26, 2023 21:11

bderusha requested review from a team as code owners May 26, 2023 21:12

Hannah Kennedy added 2 commits May 26, 2023 17:18

Updating some javadocs and Years.

22aacbd

Signed-off-by: Hannah Kennedy <hakenned@microsoft.com>

Add missing Header

cf3f60f

Signed-off-by: Hannah Kennedy <hakenned@microsoft.com>

cgillum reviewed May 31, 2023

View reviewed changes

bderusha added 2 commits June 1, 2023 12:55

respond to PR feedback

c6e3b5e

Signed-off-by: Bill DeRusha <444835+bderusha@users.noreply.github.com>

Update workflow example README

3cfd8c1

Signed-off-by: Bill DeRusha <444835+bderusha@users.noreply.github.com>

cgillum reviewed Jun 1, 2023

View reviewed changes

Address PR feedback

a6cfda9

Signed-off-by: Bill DeRusha <444835+bderusha@users.noreply.github.com>

bderusha added 2 commits June 2, 2023 11:59

fixup deprecated pom.xml variable

1ed1940

Signed-off-by: Bill DeRusha <444835+bderusha@users.noreply.github.com>

Updates based on PR feedback

452a4d9

Signed-off-by: Bill DeRusha <444835+bderusha@users.noreply.github.com>

cgillum reviewed Jun 6, 2023

View reviewed changes

johnewart reviewed Jun 6, 2023

View reviewed changes

examples/pom.xml Outdated Show resolved Hide resolved

pom.xml Outdated Show resolved Hide resolved

Update pom files per feedback

9b2881b

Signed-off-by: Bill DeRusha <444835+bderusha@users.noreply.github.com>

Merge branch 'dapr:master' into master

888b6e5

artursouza requested changes Jun 29, 2023

View reviewed changes

Merge branch 'master' into master

28898e4

This was referenced Aug 2, 2023

[docs] Workflow how-to and client example #890

Merged

[docs] Workflow docs for Java SDK dapr/docs#3662

Merged

Use Mono and refactor GRPC managed channel builder

1cfae5e

Signed-off-by: Bill DeRusha <444835+bderusha@users.noreply.github.com>

Fix example unit tests

c9f6d1d

Signed-off-by: Bill DeRusha <444835+bderusha@users.noreply.github.com>

skyao suggested changes Aug 8, 2023

View reviewed changes

Implement PR feedback

2aba320

Signed-off-by: Bill DeRusha <444835+bderusha@users.noreply.github.com>

artursouza requested changes Aug 8, 2023

View reviewed changes

bderusha added 3 commits August 9, 2023 17:17

PR Feedback: Revert Mono usage + pom.xml changes

6af50b5

Signed-off-by: Bill DeRusha <444835+bderusha@users.noreply.github.com>

pom.xml version fixes

4a53c4e

Signed-off-by: Bill DeRusha <444835+bderusha@users.noreply.github.com>

Remove Mono entirely from workflows

904e41e

Signed-off-by: Bill DeRusha <444835+bderusha@users.noreply.github.com>

artursouza approved these changes Aug 11, 2023

View reviewed changes

artursouza merged commit 6d65991 into dapr:master Aug 11, 2023

mukundansundar added this to the v1.10 milestone Sep 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial Workflow SDK #857

Initial Workflow SDK #857

bderusha commented May 11, 2023 •

edited

Loading

nyemade-uversky commented May 15, 2023

bderusha commented May 23, 2023

cgillum left a comment

bderusha commented Jun 1, 2023

cgillum left a comment

bderusha commented Jun 2, 2023

cgillum left a comment

bderusha commented Jun 6, 2023

cgillum commented Jun 6, 2023

johnewart left a comment

bderusha commented Jun 7, 2023

nyemade-uversky commented Jun 7, 2023

olitomlinson commented Jun 9, 2023

bderusha commented Jun 26, 2023

nyemade-uversky commented Jun 27, 2023

bderusha commented Jun 27, 2023

bderusha commented Jun 28, 2023

artursouza left a comment

bderusha commented Jun 30, 2023

artursouza commented Jul 3, 2023

artursouza commented Jul 5, 2023

NarmathaBala commented Jul 11, 2023 •

edited

Loading

brunoborges commented Jul 18, 2023

craprivatebeta commented Jul 20, 2023

mukundansundar commented Aug 1, 2023

bderusha commented Aug 2, 2023

bderusha commented Aug 3, 2023

skyao left a comment

artursouza Aug 8, 2023

bderusha Aug 9, 2023

skyao Aug 10, 2023

artursouza Aug 10, 2023

codecov bot commented Aug 10, 2023

Initial Workflow SDK #857

Initial Workflow SDK #857

Conversation

bderusha commented May 11, 2023 • edited Loading

Description

Issue reference

Checklist

nyemade-uversky commented May 15, 2023

bderusha commented May 23, 2023

cgillum left a comment

Choose a reason for hiding this comment

bderusha commented Jun 1, 2023

cgillum left a comment

Choose a reason for hiding this comment

bderusha commented Jun 2, 2023

cgillum left a comment

Choose a reason for hiding this comment

bderusha commented Jun 6, 2023

cgillum commented Jun 6, 2023

johnewart left a comment

Choose a reason for hiding this comment

bderusha commented Jun 7, 2023

nyemade-uversky commented Jun 7, 2023

olitomlinson commented Jun 9, 2023

bderusha commented Jun 26, 2023

nyemade-uversky commented Jun 27, 2023

bderusha commented Jun 27, 2023

bderusha commented Jun 28, 2023

artursouza left a comment

Choose a reason for hiding this comment

bderusha commented Jun 30, 2023

artursouza commented Jul 3, 2023

artursouza commented Jul 5, 2023

NarmathaBala commented Jul 11, 2023 • edited Loading

brunoborges commented Jul 18, 2023

craprivatebeta commented Jul 20, 2023

mukundansundar commented Aug 1, 2023

bderusha commented Aug 2, 2023

bderusha commented Aug 3, 2023

skyao left a comment

Choose a reason for hiding this comment

artursouza Aug 8, 2023

Choose a reason for hiding this comment

bderusha Aug 9, 2023

Choose a reason for hiding this comment

skyao Aug 10, 2023

Choose a reason for hiding this comment

artursouza Aug 10, 2023

Choose a reason for hiding this comment

codecov bot commented Aug 10, 2023

Codecov Report

bderusha commented May 11, 2023 •

edited

Loading

NarmathaBala commented Jul 11, 2023 •

edited

Loading