Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Workflow how-to and client example #890

Merged
merged 12 commits into from
Sep 20, 2023
Merged

Conversation

hhunter-ms
Copy link
Contributor

@hhunter-ms hhunter-ms commented Aug 2, 2023

Description

Add docs alongside new Java SDK workflow example

Issue reference

PR will close: #881
Related issue and PR:

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@hhunter-ms hhunter-ms requested review from a team as code owners August 2, 2023 20:11
@hhunter-ms
Copy link
Contributor Author

/assign

hhunter-ms and others added 2 commits September 6, 2023 13:25
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
hhunter-ms and others added 4 commits September 13, 2023 11:41
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com>
@hhunter-ms
Copy link
Contributor Author

@bderusha @macromania I did some rearranging of _index.md pages, but do you mind taking a look at the documentation for the workflow Java SDK sample (java-workflow.md) and the workflow client sample (java-client.md)?

@hhunter-ms hhunter-ms changed the title [docs][WIP] Workflow docs [docs] Workflow docs Sep 13, 2023
@hhunter-ms hhunter-ms changed the title [docs] Workflow docs [docs] Workflow how-to and client example Sep 13, 2023
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
msfussell
msfussell previously approved these changes Sep 13, 2023
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@RyanLettieri RyanLettieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment

daprdocs/content/en/java-sdk-docs/_index.md Outdated Show resolved Hide resolved
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (447ff86) 76.47% compared to head (0a52420) 76.47%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #890   +/-   ##
=========================================
  Coverage     76.47%   76.47%           
  Complexity     1398     1398           
=========================================
  Files           132      132           
  Lines          4264     4264           
  Branches        497      497           
=========================================
  Hits           3261     3261           
  Misses          743      743           
  Partials        260      260           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artursouza artursouza merged commit b442ba4 into dapr:master Sep 20, 2023
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[docs] Workflow for Java SDK
4 participants